'Re: Review Request: Manual panel hiding [WIP]'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Manual panel hiding [WIP]
From:       "Beat Wolf" <asraniel () fryx ! ch>
Date:       2010-09-24 10:45:28
Message-ID: 20100924104528.1829.50118 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/3121/#review7754
-----------------------------------------------------------

what is the status of this patch?

- Beat

On 2010-03-04 19:19:53, Andrzej JR Hunt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/3121/
> -----------------------------------------------------------
> 
> (Updated 2010-03-04 19:19:53)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Manual panel hiding patch (still in progress). Currently only horizontal panels are \
> properly implemented, there is still a display bug whereby the plasma toolbox \
> (cashew) ignores the contentsMargins set on the containment and thus gets covered \
> by the hiding buttons. 
> 
> This addresses bug 158556.
> https://bugs.kde.org/show_bug.cgi?id=158556
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelcontroller.h 1097398 
> /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelcontroller.cpp 1097398 
> /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelview.h 1097398 
> /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelview.cpp 1097398 
> /trunk/KDE/kdebase/workspace/plasma/desktop/shell/scripting/panel.cpp 1097398 
> 
> Diff: http://svn.reviewboard.kde.org/r/3121/diff
> 
> 
> Testing
> -------
> 
> Hiding the panels, changing states, changing positions and sizes.
> 
> 
> Thanks,
> 
> Andrzej JR
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/3121/">http://svn.reviewboard.kde.org/r/3121/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">what is the status of \
this patch?</pre>  <br />

<p>- Beat</p>

<br />
<p>On March 4th, 2010, 7:19 p.m., Andrzej JR Hunt wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Andrzej JR Hunt.</div>

<p style="color: grey;"><i>Updated 2010-03-04 19:19:53</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Manual panel hiding patch (still in progress). Currently only horizontal \
panels are properly implemented, there is still a display bug whereby the plasma \
toolbox (cashew) ignores the contentsMargins set on the containment and thus gets \
covered by the hiding buttons.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hiding the panels, changing states, changing positions and sizes.</pre>  \
</td>  </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=158556">158556</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelcontroller.h <span \
style="color: grey">(1097398)</span></li>

 <li>/trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelcontroller.cpp <span \
style="color: grey">(1097398)</span></li>

 <li>/trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelview.h <span \
style="color: grey">(1097398)</span></li>

 <li>/trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelview.cpp <span \
style="color: grey">(1097398)</span></li>

 <li>/trunk/KDE/kdebase/workspace/plasma/desktop/shell/scripting/panel.cpp <span \
style="color: grey">(1097398)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/3121/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 