From kde-panel-devel Fri Sep 24 10:42:09 2010 From: "Beat Wolf" Date: Fri, 24 Sep 2010 10:42:09 +0000 To: kde-panel-devel Subject: Re: Review Request: Supporting theme colors on the fifteenPuzzle Message-Id: <20100924104209.1648.59812 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=128532499405193 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2082187624==" --===============2082187624== Content-Type: multipart/alternative; boundary="===============1791431568083432142==" --===============1791431568083432142== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4904/#review7752 ----------------------------------------------------------- what is the status of this patch? - Beat On 2010-08-04 18:13:29, Alex Raymond wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/4904/ > ----------------------------------------------------------- > = > (Updated 2010-08-04 18:13:29) > = > = > Review request for Plasma, Aaron Seigo and Tomaz Canabrava. > = > = > Summary > ------- > = > This patch automatically adds the current background Plasma color as the = first in the KColorCombo list. :) > = > = > Diffs > ----- > = > /trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzle.cp= p 1159160 = > /trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzleCon= fig.cpp 1159160 = > = > Diff: http://svn.reviewboard.kde.org/r/4904/diff > = > = > Testing > ------- > = > It works fine, but there is still a problem. If you manually select a the= me color, and have your theme changed afterwards, you will need to manually= re-select the theme color on the list in order to make it go for the right= one. Any suggestions? > = > = > Thanks, > = > Alex > = > --===============1791431568083432142== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/4904/ 

what is th=
e status of this patch?

- Beat


On August 4th, 2010, 6:13 p.m., Alex Raymond wrote:

Review request for Plasma, Aaron Seigo and Tomaz Canabrava.
By Alex Raymond.

Updated 2010-08-04 18:13:29

Descripti= on 

This patch automatically adds the current background Plasma =
color as the first in the KColorCombo list. :)

Testing <= /h1> 
It works fine, but there is still a problem. If you manually=
 select a theme color, and have your theme changed afterwards, you will nee=
d to manually re-select the theme color on the list in order to make it go =
for the right one. Any suggestions?

Diffs=

  • /trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzle.c= pp (1159160)
  • /trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzleCo= nfig.cpp (1159160)

View Diff
--===============1791431568083432142==-- --===============2082187624== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============2082187624==--