[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: InputTypeWatcher, to "mobilize" the plasma widgets
From: "Beat Wolf" <asraniel () fryx ! ch>
Date: 2010-09-24 10:27:18
Message-ID: 20100924102718.1386.13864 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/3914/#review7746
-----------------------------------------------------------
should this review request be marked as rejected? (is this even possible?)
- Beat
On 2010-05-07 17:58:06, Marco Martin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/3914/
> -----------------------------------------------------------
> =
> (Updated 2010-05-07 17:58:06)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> this little class (that probably have to stay private) is a little centra=
l place for widget to see how they should behave. with touchscreen some th=
ings have to change for everybody, like refusing hover events, always.
> other widgets will have to change even more, for instance ScrollWidget wi=
ll have to replace the scrollbars with some simple scroll indicators that a=
ppears over the contents and only while animating.
> it's now done with a simpe config file, it would be cool doing it complet=
ely dinamically, and actually by querying the hardware. but i don't thiunk =
it exists any sane system to hgave reliably thi kind of informations (like =
if a poiter devie is a mouse otr a touchscreen) so for now it would have to=
be manually configured.
> It kinda sucks, but i think it's a quite important feature anyways, quite=
crucial for touchscreens, and would be still easy to change if is going to=
stay private for now
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdelibs/plasma/CMakeLists.txt 1123761 =
> /trunk/KDE/kdelibs/plasma/private/inputtypewatcher.cpp PRE-CREATION =
> /trunk/KDE/kdelibs/plasma/private/inputtypewatcher_p.h PRE-CREATION =
> /trunk/KDE/kdelibs/plasma/widgets/pushbutton.cpp 1123761 =
> =
> Diff: http://svn.reviewboard.kde.org/r/3914/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Marco
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/3914/">http://svn.reviewboard.kde.org/r/3914/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">should this review \
request be marked as rejected? (is this even possible?)</pre> <br />
<p>- Beat</p>
<br />
<p>On May 7th, 2010, 5:58 p.m., Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated 2010-05-07 17:58:06</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">this little class (that probably have to stay private) is a little \
central place for widget to see how they should behave. with touchscreen some things \
have to change for everybody, like refusing hover events, always. other widgets will \
have to change even more, for instance ScrollWidget will have to replace the \
scrollbars with some simple scroll indicators that appears over the contents and only \
while animating. it's now done with a simpe config file, it would be cool doing \
it completely dinamically, and actually by querying the hardware. but i don't \
thiunk it exists any sane system to hgave reliably thi kind of informations (like if \
a poiter devie is a mouse otr a touchscreen) so for now it would have to be manually \
configured. It kinda sucks, but i think it's a quite important feature anyways, \
quite crucial for touchscreens, and would be still easy to change if is going to stay \
private for now</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/plasma/CMakeLists.txt <span style="color: \
grey">(1123761)</span></li>
<li>/trunk/KDE/kdelibs/plasma/private/inputtypewatcher.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/plasma/private/inputtypewatcher_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/plasma/widgets/pushbutton.cpp <span style="color: \
grey">(1123761)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/3914/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic