[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Workaround plasma tooltips causing "holes" in
From: "Aaron Seigo" <aseigo () kde ! org>
Date: 2010-09-23 0:42:37
Message-ID: 20100923004237.25981.60829 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5415/#review7725
-----------------------------------------------------------
Ship it!
this doesn't fix other ways to reproduce this bug, e.g. drop down menus. bu=
t this is probably the most common cause. (that it happens when showing a w=
indow that was previously shown only is an interesting clue for the x.org p=
eople, perhaps.) however, given that this bug has been sitting there unfixe=
d for a couple of _years_ now with no fix in sight and that this is the mos=
t prevalent cause, coupled with it not really being a huge hack in libplasm=
a, i'm in favour of this change in spite of the "don't work around bugs" ph=
ilosophy. cheers ...
- Aaron
On 2010-09-22 23:13:41, Anthony Bryant wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5415/
> -----------------------------------------------------------
> =
> (Updated 2010-09-22 23:13:41)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> Works around an X bug that causes plasma tooltips to leave behind weird h=
oles in windows (when compositing is off): If you trigger a tooltip which h=
as a window under it, let the tooltip disappear, and then trigger a tooltip=
somewhere else, a hole appears in the window where the first tooltip used =
to be.
> Basically, this patch deletes the tooltip's window whenever it is hidden,=
and re-creates it when it is shown.
> Since it's a different window being shown the next time, the X bug doesn'=
t happen.
> =
> I know this is a workaround for an X bug, so if you want to discard this =
patch and see X get fixed instead, then I can sympathize.
> However, this workaround doesn't introduce any hacks into libplasma, it j=
ust deletes a window when it isn't actually in use.
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdelibs/plasma/tooltipmanager.cpp 1178011 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5415/diff
> =
> =
> Testing
> -------
> =
> Hovered over several plasmoids, and checked that changing the tooltip whi=
le it is still visible works as well as deleting and re-creating it.
> =
> =
> Thanks,
> =
> Anthony
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5415/">http://svn.reviewboard.kde.org/r/5415/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this doesn't fix \
other ways to reproduce this bug, e.g. drop down menus. but this is probably the most \
common cause. (that it happens when showing a window that was previously shown only \
is an interesting clue for the x.org people, perhaps.) however, given that this bug \
has been sitting there unfixed for a couple of _years_ now with no fix in sight and \
that this is the most prevalent cause, coupled with it not really being a huge hack \
in libplasma, i'm in favour of this change in spite of the "don't work \
around bugs" philosophy. cheers ...</pre> <br />
<p>- Aaron</p>
<br />
<p>On September 22nd, 2010, 11:13 p.m., Anthony Bryant wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Anthony Bryant.</div>
<p style="color: grey;"><i>Updated 2010-09-22 23:13:41</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works around an X bug that causes plasma tooltips to leave behind weird \
holes in windows (when compositing is off): If you trigger a tooltip which has a \
window under it, let the tooltip disappear, and then trigger a tooltip somewhere \
else, a hole appears in the window where the first tooltip used to be. Basically, \
this patch deletes the tooltip's window whenever it is hidden, and re-creates it \
when it is shown. Since it's a different window being shown the next time, the X \
bug doesn't happen.
I know this is a workaround for an X bug, so if you want to discard this patch and \
see X get fixed instead, then I can sympathize. However, this workaround doesn't \
introduce any hacks into libplasma, it just deletes a window when it isn't \
actually in use.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hovered over several plasmoids, and checked that changing the tooltip \
while it is still visible works as well as deleting and re-creating it.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/plasma/tooltipmanager.cpp <span style="color: \
grey">(1178011)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5415/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic