[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Cleanups in pager
From: "Anthony Bryant" <antjbryant () gmail ! com>
Date: 2010-09-17 16:45:48
Message-ID: 20100917164548.18476.19036 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-09-17 16:18:36, Aaron Seigo wrote:
> > the patch doesn't apply to current trunk .. could you update the review board \
> > request? thanks :)
I thought I did that yesterday (and there haven't been any commits to pager since \
then), does it still not apply?
- Anthony
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5355/#review7667
-----------------------------------------------------------
On 2010-09-17 02:29:59, Anthony Bryant wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5355/
> -----------------------------------------------------------
>
> (Updated 2010-09-17 02:29:59)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> * Make configAccepted() just write the new config, and make configChanged() \
> conditionally update the plasmoid after reading the config back in.
> * Split the grid resizing logic into its own method: recalculateGridSizes(int \
> rows), and make it detect more edge cases.
> * Rename the main size calculation method to updateSizes(bool allowResize), which \
> will resize the applet to its preferred size if allowResize is \
> true.
> * Fix a bug which caused applet resizes to be wrongly cancelled in some situations.
> * Code style cleanups, remove unused variables, etc.
>
> (Sorry for putting so many changes into one patch)
>
>
> This addresses bug 250756.
> https://bugs.kde.org/show_bug.cgi?id=250756
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/pager/pager.h 1176214
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/pager/pager.cpp 1176214
>
> Diff: http://svn.reviewboard.kde.org/r/5355/diff
>
>
> Testing
> -------
>
> Tested configuring the pager from the config interface and the desktop console, and \
> that it responds correctly to changes in desktop count, and in FormFactor and size. \
>
> Thanks,
>
> Anthony
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5355/">http://svn.reviewboard.kde.org/r/5355/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 17th, 2010, 4:18 p.m., <b>Aaron \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">the patch doesn't apply to current trunk .. could you update the \
review board request? thanks :)</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I thought I did that \
yesterday (and there haven't been any commits to pager since then), does it still \
not apply?</pre> <br />
<p>- Anthony</p>
<br />
<p>On September 17th, 2010, 2:29 a.m., Anthony Bryant wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Anthony Bryant.</div>
<p style="color: grey;"><i>Updated 2010-09-17 02:29:59</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* Make configAccepted() just write the new config, and make \
configChanged() conditionally update the plasmoid after reading the \
config back in.
* Split the grid resizing logic into its own method: recalculateGridSizes(int rows), \
and make it detect more edge cases.
* Rename the main size calculation method to updateSizes(bool allowResize), which \
will resize the applet to its preferred size if allowResize is true.
* Fix a bug which caused applet resizes to be wrongly cancelled in some situations.
* Code style cleanups, remove unused variables, etc.
(Sorry for putting so many changes into one patch)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested configuring the pager from the config interface and the desktop \
console, and that it responds correctly to changes in desktop count, and in \
FormFactor and size.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=250756">250756</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/pager/pager.h <span \
style="color: grey">(1176214)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/pager/pager.cpp <span \
style="color: grey">(1176214)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5355/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic