[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Frame applet should give valid message when
From: "Sujith H" <sujith.h () gmail ! com>
Date: 2010-09-16 19:06:29
Message-ID: 20100916190629.23641.63107 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-09-16 11:20:34, Sebastian Kügler wrote:
> > One small issue with i18n context left, otherwise it's good to go in (from my \
> > point of view, better wait for annma to mark it as ship it as well).
Thanks. I will do it right away :)
> On 2010-09-16 11:20:34, Sebastian Kügler wrote:
> > trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp, line 88
> > <http://svn.reviewboard.kde.org/r/5362/diff/4/?file=36015#file36015line88>
> >
> > i18n context should be more useful.
>
> Anne-Marie Mahfouf wrote:
> I agree with Sebas, ship it and thanks for looking in this issue!
> As for the context help for translators, maybe we can put i18nc("Text written on \
> default picture", "Dropped folder is empty. Please drop a folder with image(s)");
Thanks Anne-Marie :)
- Sujith
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5362/#review7637
-----------------------------------------------------------
On 2010-09-16 03:54:44, Sujith H wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5362/
> -----------------------------------------------------------
>
> (Updated 2010-09-16 03:54:44)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> This diff will give the user meaningful message when a folder is dropped to the \
> frame applet and if it doesn't contain image(s).
>
> Diffs
> -----
>
> trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1174498
> trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1174498
> trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1174498
> trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1174498
>
> Diff: http://svn.reviewboard.kde.org/r/5362/diff
>
>
> Testing
> -------
>
> This has been tested.
>
>
> Thanks,
>
> Sujith
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5362/">http://svn.reviewboard.kde.org/r/5362/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 16th, 2010, 11:20 a.m., <b>Sebastian \
Kügler</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">One small issue with i18n context left, otherwise it's good to go in \
(from my point of view, better wait for annma to mark it as ship it as well).</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks. I will do it \
right away :)</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 16th, 2010, 11:20 a.m., <b>Sebastian \
Kügler</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/5362/diff/4/?file=36015#file36015line88" style="color: black; font-weight: \
bold; text-decoration: \
underline;">trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Picture::setPicture(const KUrl &currentUrl)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">88</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">m_message</span> <span class="o">=</span> <span \
class="n">i18nc</span><span class="p">(</span><span \
class="s">"Info"</span><span class="p">,</span> <span \
class="s">"Dropped folder is empty. Please drop a folder with \
image(s)"</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i18n context should be \
more useful.</pre> </blockquote>
<p>On September 16th, 2010, 12:34 p.m., <b>Anne-Marie Mahfouf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree with Sebas, ship \
it and thanks for looking in this issue! As for the context help for translators, \
maybe we can put i18nc("Text written on default picture", "Dropped \
folder is empty. Please drop a folder with image(s)");</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks \
Anne-Marie :)</pre> <br />
<p>- Sujith </p>
<br />
<p>On September 16th, 2010, 3:54 a.m., Sujith H wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Sujith H.</div>
<p style="color: grey;"><i>Updated 2010-09-16 03:54:44</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This diff will give the user meaningful message when a folder is dropped \
to the frame applet and if it doesn't contain image(s).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This has been tested. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdeplasma-addons/applets/frame/picture.h <span style="color: \
grey">(1174498)</span></li>
<li>trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp <span style="color: \
grey">(1174498)</span></li>
<li>trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h <span style="color: \
grey">(1174498)</span></li>
<li>trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp <span style="color: \
grey">(1174498)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5362/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic