'Re: Review Request: Extend FolderView::configChanged() to reload'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Extend FolderView::configChanged() to reload
From:       "Rohan Garg" <rohangarg () ubuntu ! com>
Date:       2010-09-15 17:37:24
Message-ID: 20100915173724.20520.90766 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5049/
-----------------------------------------------------------

(Updated 2010-09-15 17:37:23.970844)

Review request for Plasma and Fredrik H=C3=B6glund.

Changes
-------

formatting++

Summary
-------

Extend FolderView::configChanged() such that all configuration options are =
read there on FolderView start. This will ensure that configuration changes=
 made "behind its back" (e.g. by the Desktop Scripting) will take effect.

Diffs (updated)
-----

  /trunk/KDE/kdebase/apps/plasma/applets/folderview/folderview.cpp 1173894 =

Diff: http://svn.reviewboard.kde.org/r/5049/diff

Testing
-------

Testing done, seems to be OK at my end

Thanks,

Rohan

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5049/">http://svn.reviewboard.kde.org/r/5049/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Fredrik Höglund.</div>
<div>By Rohan Garg.</div>

<p style="color: grey;"><i>Updated 2010-09-15 17:37:23.970844</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">formatting++</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Extend FolderView::configChanged() such that all configuration options \
are read there on FolderView start. This will ensure that configuration changes made \
&quot;behind its back&quot; (e.g. by the Desktop Scripting) will take effect.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Testing done, seems to be OK at my end</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdebase/apps/plasma/applets/folderview/folderview.cpp <span \
style="color: grey">(1173894)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5049/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 