[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Add an unit test for Plasma::ConfigLoader
From: "Aaron Seigo" <aseigo () kde ! org>
Date: 2010-09-13 18:12:28
Message-ID: 20100913181228.24496.54262 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5329/#review7582
-----------------------------------------------------------
Ship it!
looks great; and it shows a problem in ConfigLoader -> it should be using i=
nt, not qint32 for the integer list. nice! :)
- Aaron
On 2010-09-13 17:51:03, Martin Blumenstingl wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5329/
> -----------------------------------------------------------
> =
> (Updated 2010-09-13 17:51:03)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> Currently I'm changing some of the code in Plasma::ConfigLoader.
> I want to make sure that I don't break that much ;)
> =
> Thus I wrote a unit test for the config loader.
> Currently all it does it testing if the config loader can parse the defau=
lt-values correctly.
> One test for each (data-)"type" which ConfigLoader can handle.
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdelibs/plasma/tests/configloadertest.xml PRE-CREATION =
> /trunk/KDE/kdelibs/plasma/tests/CMakeLists.txt 1174512 =
> /trunk/KDE/kdelibs/plasma/tests/configloadertest.h PRE-CREATION =
> /trunk/KDE/kdelibs/plasma/tests/configloadertest.cpp PRE-CREATION =
> =
> Diff: http://svn.reviewboard.kde.org/r/5329/diff
> =
> =
> Testing
> -------
> =
> I ran the tests on my box.
> All of them were successful.
> =
> =
> Thanks,
> =
> Martin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5329/">http://svn.reviewboard.kde.org/r/5329/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks great; and it \
shows a problem in ConfigLoader -> it should be using int, not qint32 for the \
integer list. nice! :)</pre> <br />
<p>- Aaron</p>
<br />
<p>On September 13th, 2010, 5:51 p.m., Martin Blumenstingl wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Blumenstingl.</div>
<p style="color: grey;"><i>Updated 2010-09-13 17:51:03</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently I'm changing some of the code in Plasma::ConfigLoader. I \
want to make sure that I don't break that much ;)
Thus I wrote a unit test for the config loader.
Currently all it does it testing if the config loader can parse the default-values \
correctly. One test for each (data-)"type" which ConfigLoader can \
handle.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I ran the tests on my box. All of them were successful.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/plasma/tests/configloadertest.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/plasma/tests/CMakeLists.txt <span style="color: \
grey">(1174512)</span></li>
<li>/trunk/KDE/kdelibs/plasma/tests/configloadertest.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/plasma/tests/configloadertest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5329/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic