[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: configChanged() for the Tasks plasmoid
From: "Aaron Seigo" <aseigo () kde ! org>
Date: 2010-09-11 17:27:30
Message-ID: 20100911172730.16820.48932 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5313/#review7545
-----------------------------------------------------------
Ship it!
looks good; another plasmoid down! :)
/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.cpp
<http://svn.reviewboard.kde.org/r/5313/#comment7713>
usually put the conditional on the end of the line above, e.g.:
=
if (item->abstractItem() &&
item->abstractItem()->..
- Aaron
On 2010-09-11 02:00:33, Anthony Bryant wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5313/
> -----------------------------------------------------------
> =
> (Updated 2010-09-11 02:00:33)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> Add configChanged() to the Tasks plasmoid, and fix a few warnings.
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaski=
tem.cpp 1173935 =
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem=
.cpp 1173935 =
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayou=
t.cpp 1173935 =
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.h 11739=
35 =
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp 117=
3935 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5313/diff
> =
> =
> Testing
> -------
> =
> Tested that tooltips can be toggled from both the UI and the desktop cons=
ole, and that the other options still work from the UI.
> =
> =
> Thanks,
> =
> Anthony
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5313/">http://svn.reviewboard.kde.org/r/5313/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks good; another \
plasmoid down! :)</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/5313/diff/1/?file=35673#file35673line349" style="color: black; font-weight: \
bold; text-decoration: \
underline;">/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
TaskItemLayout::layoutItems()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">349</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">item</span><span \
class="o">-></span><span class="n">abstractItem</span><span \
class="p">()</span><span class="hl"> </span><span class="o"><span \
class="hl">&&</span></span><span class="hl"> </span><span class="n"><span \
class="hl">item</span></span><span class="o"><span \
class="hl">-></span></span><span class="n"><span \
class="hl">abstractItem</span></span><span class="p"><span \
class="hl">()</span></span><span class="o"><span class="hl">-></span></span><span \
class="n"><span class="hl">isGroupItem</span></span><span class="p"><span \
class="hl">())</span></span><span class="hl"> </span><span class="p"><span \
class="hl">{</span></span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">349</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span \
class="p">(</span><span class="n">item</span><span class="o">-></span><span \
class="n">abstractItem</span><span class="p">()</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">350</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="o">&&</span> <span class="n">item</span><span \
class="o">-></span><span class="n">abstractItem</span><span \
class="p">()</span><span class="o">-></span><span class="n">itemType</span><span \
class="p">()</span> <span class="o">==</span> <span class="n">TaskManager</span><span \
class="o">::</span><span class="n">GroupItemType</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">usually put \
the conditional on the end of the line above, e.g.:
if (item->abstractItem() &&
item->abstractItem()->..</pre>
</div>
<br />
<p>- Aaron</p>
<br />
<p>On September 11th, 2010, 2 a.m., Anthony Bryant wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Anthony Bryant.</div>
<p style="color: grey;"><i>Updated 2010-09-11 02:00:33</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add configChanged() to the Tasks plasmoid, and fix a few warnings.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested that tooltips can be toggled from both the UI and the desktop \
console, and that the other options still work from the UI.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.cpp \
<span style="color: grey">(1173935)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.cpp \
<span style="color: grey">(1173935)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.cpp \
<span style="color: grey">(1173935)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.h <span \
style="color: grey">(1173935)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp <span \
style="color: grey">(1173935)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5313/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic