[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: New Applet handle system
From: "Giulio Camuffo" <giuliocamuffo () gmail ! com>
Date: 2010-09-03 17:40:29
Message-ID: 20100903174029.3905.40076 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-09-03 15:59:17, Aaron Seigo wrote:
> > the patch does not apply cleanly to trunk; it needs to be updated / regenerated.
> >
> > instead of putting all of these classes into private/, i think it may make more \
> > sense to start a new dir in kdeliba/plasma/ called e.g. handles/, much as we did \
> > for animations.
> > i've also included some comments on ControlElement as a starting point.
the patch was done against the last revision. i don't know what to do about it.
> On 2010-09-03 15:59:17, Aaron Seigo wrote:
> > trunk/KDE/kdelibs/plasma/private/controlelement.cpp, lines 70-83
> > <http://svn.reviewboard.kde.org/r/5155/diff/2/?file=34957#file34957line70>
> >
> > i don't think this belongs in ControlElement. it may make sense inside \
> > MoveElement, or could even be handled inside of the handle itself if it needs to \
> > be generic. it feels out of place here, however, and is only used by the \
> > MoveElement implementation.
agreed. as i moved it in ControlElement i realised it can really go in MoveControl.
> On 2010-09-03 15:59:17, Aaron Seigo wrote:
> > trunk/KDE/kdelibs/plasma/private/controlelement_p.h, line 38
> > <http://svn.reviewboard.kde.org/r/5155/diff/2/?file=34958#file34958line38>
> >
> > a pointer to the handle shouldn't be necessary.
but the handle provides a pointer to the containment and some things like position(). \
The ResizeControl must ask the handle to know which corner to keep static.
> On 2010-09-03 15:59:17, Aaron Seigo wrote:
> > trunk/KDE/kdelibs/plasma/private/desktophandle.h, line 1
> > <http://svn.reviewboard.kde.org/r/5155/diff/2/?file=34959#file34959line1>
> >
> > this file needs to be a _p.h
just, there's already a _p.h. I thought that since it will become public it can stay \
as it is for now.
- Giulio
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5155/#review7383
-----------------------------------------------------------
On 2010-09-01 16:22:54, Giulio Camuffo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5155/
> -----------------------------------------------------------
>
> (Updated 2010-09-01 16:22:54)
>
>
> Review request for Plasma, Aaron Seigo and Marco Martin.
>
>
> Summary
> -------
>
> This is a rewamp of the Applet handle system. Through its modular architecture it \
> easily allows modifications and reuse of code.
> It features a base Handle class, AbstractHandle, and a base class for the control \
> elements, ControlElement. I developed an handle based on the actual AppletHandle, \
> DesktopHandle, and the control elements for the usual operations.
>
> Diffs
> -----
>
> trunk/KDE/kdelibs/plasma/CMakeLists.txt 1170608
> trunk/KDE/kdelibs/plasma/applet.h 1170608
> trunk/KDE/kdelibs/plasma/applet.cpp 1170608
> trunk/KDE/kdelibs/plasma/containment.h 1170608
> trunk/KDE/kdelibs/plasma/containment.cpp 1170608
> trunk/KDE/kdelibs/plasma/extenders/extender.cpp 1170608
> trunk/KDE/kdelibs/plasma/extenders/extenderitem.cpp 1170608
> trunk/KDE/kdelibs/plasma/private/abstracthandle.h PRE-CREATION
> trunk/KDE/kdelibs/plasma/private/abstracthandle.cpp PRE-CREATION
> trunk/KDE/kdelibs/plasma/private/applet_p.h 1170608
> trunk/KDE/kdelibs/plasma/private/applethandle.cpp 1170608
> trunk/KDE/kdelibs/plasma/private/applethandle_p.h 1170608
> trunk/KDE/kdelibs/plasma/private/configurecontrol.h PRE-CREATION
> trunk/KDE/kdelibs/plasma/private/configurecontrol.cpp PRE-CREATION
> trunk/KDE/kdelibs/plasma/private/containment_p.h 1170608
> trunk/KDE/kdelibs/plasma/private/controlelement.h PRE-CREATION
> trunk/KDE/kdelibs/plasma/private/controlelement.cpp PRE-CREATION
> trunk/KDE/kdelibs/plasma/private/controlelement_p.h PRE-CREATION
> trunk/KDE/kdelibs/plasma/private/desktophandle.h PRE-CREATION
> trunk/KDE/kdelibs/plasma/private/desktophandle.cpp PRE-CREATION
> trunk/KDE/kdelibs/plasma/private/maximizecontrol.h PRE-CREATION
> trunk/KDE/kdelibs/plasma/private/maximizecontrol.cpp PRE-CREATION
> trunk/KDE/kdelibs/plasma/private/movecontrol.h PRE-CREATION
> trunk/KDE/kdelibs/plasma/private/movecontrol.cpp PRE-CREATION
> trunk/KDE/kdelibs/plasma/private/removecontrol.h PRE-CREATION
> trunk/KDE/kdelibs/plasma/private/removecontrol.cpp PRE-CREATION
> trunk/KDE/kdelibs/plasma/private/resizecontrol.h PRE-CREATION
> trunk/KDE/kdelibs/plasma/private/resizecontrol.cpp PRE-CREATION
> trunk/KDE/kdelibs/plasma/private/rotatecontrol.h PRE-CREATION
> trunk/KDE/kdelibs/plasma/private/rotatecontrol.cpp PRE-CREATION
>
> Diff: http://svn.reviewboard.kde.org/r/5155/diff
>
>
> Testing
> -------
>
> It isn't finished. It's missing the touch events management (which, however, it's \
> hard for me to do, 'cause i don't have any touch screen device) and a better drag \
> and drop system between containments. I'd like, however, to know what you think \
> about what i've done, especially about the architecture.
> What's here works, though.
>
>
> Thanks,
>
> Giulio
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5155/">http://svn.reviewboard.kde.org/r/5155/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 3rd, 2010, 3:59 p.m., <b>Aaron \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">the patch does not apply cleanly to trunk; it needs to be updated / \
regenerated.
instead of putting all of these classes into private/, i think it may make more sense \
to start a new dir in kdeliba/plasma/ called e.g. handles/, much as we did for \
animations.
i've also included some comments on ControlElement as a starting point.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the patch was done \
against the last revision. i don't know what to do about it.</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 3rd, 2010, 3:59 p.m., <b>Aaron \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/5155/diff/2/?file=34957#file34957line70" style="color: black; font-weight: \
bold; text-decoration: \
underline;">trunk/KDE/kdelibs/plasma/private/controlelement.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">AbstractHandle *ControlElement::handle() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">70</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">bool</span> <span class="n">ControlElement</span><span \
class="o">::</span><span class="n">leaveCurrentView</span><span \
class="p">(</span><span class="k">const</span> <span class="n">QPoint</span> <span \
class="o">&</span><span class="n">pos</span><span class="p">)</span> <span \
class="k">const</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">71</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="p">{</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">72</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">foreach</span> <span class="p">(</span><span class="n">QWidget</span> <span \
class="o">*</span><span class="n">widget</span><span class="p">,</span> <span \
class="n">QApplication</span><span class="o">::</span><span \
class="n">topLevelWidgets</span><span class="p">())</span> <span \
class="p">{</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">73</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">widget</span><span \
class="o">-></span><span class="n">geometry</span><span class="p">().</span><span \
class="n">contains</span><span class="p">(</span><span class="n">pos</span><span \
class="p">))</span> <span class="p">{</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">74</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="c1">//is this widget a plasma view, a different view then our current \
one,</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">75</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="c1">//AND not a dashboardview?</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">76</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">Plasma</span><span class="o">::</span><span class="n">View</span> \
<span class="o">*</span><span class="n">v</span> <span class="o">=</span> <span \
class="n">qobject_cast</span><span class="o"><</span><span \
class="n">Plasma</span><span class="o">::</span><span class="n">View</span> <span \
class="o">*></span><span class="p">(</span><span class="n">widget</span><span \
class="p">);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">77</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span class="n">v</span> <span \
class="o">&&</span> <span class="n">v</span> <span class="o">!=</span> <span \
class="n">d</span><span class="o">-></span><span class="n">handle</span><span \
class="o">-></span><span class="n">containment</span><span \
class="p">()</span><span class="o">-></span><span class="n">view</span><span \
class="p">()</span> <span class="o">&&</span> <span class="n">v</span><span \
class="o">-></span><span class="n">containment</span><span class="p">()</span> \
<span class="o">!=</span> <span class="n">d</span><span class="o">-></span><span \
class="n">handle</span><span class="o">-></span><span \
class="n">containment</span><span class="p">())</span> <span \
class="p">{</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">78</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">return</span> <span class="kc">true</span><span \
class="p">;</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">79</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="p">}</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">80</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">}</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">81</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">}</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">82</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">return</span> <span class="kc">false</span><span \
class="p">;</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">83</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="p">}</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i don't think this \
belongs in ControlElement. it may make sense inside MoveElement, or could even be \
handled inside of the handle itself if it needs to be generic. it feels out of place \
here, however, and is only used by the MoveElement implementation.</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">agreed. as \
i moved it in ControlElement i realised it can really go in MoveControl.</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 3rd, 2010, 3:59 p.m., <b>Aaron \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/5155/diff/2/?file=34958#file34958line38" style="color: black; font-weight: \
bold; text-decoration: \
underline;">trunk/KDE/kdelibs/plasma/private/controlelement_p.h</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">class ControlElementPrivate</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">38</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">AbstractHandle</span> <span class="o">*</span><span \
class="n">handle</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">a pointer to the handle \
shouldn't be necessary.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">but the \
handle provides a pointer to the containment and some things like position(). The \
ResizeControl must ask the handle to know which corner to keep static.</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 3rd, 2010, 3:59 p.m., <b>Aaron \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/5155/diff/2/?file=34959#file34959line1" style="color: black; font-weight: \
bold; text-decoration: \
underline;">trunk/KDE/kdelibs/plasma/private/desktophandle.h</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm">/*</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this file needs to be a \
_p.h</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">just, \
there's already a _p.h. I thought that since it will become public it can stay as \
it is for now.</pre> <br />
<p>- Giulio</p>
<br />
<p>On September 1st, 2010, 4:22 p.m., Giulio Camuffo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Aaron Seigo and Marco Martin.</div>
<div>By Giulio Camuffo.</div>
<p style="color: grey;"><i>Updated 2010-09-01 16:22:54</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is a rewamp of the Applet handle system. Through its modular \
architecture it easily allows modifications and reuse of code.
It features a base Handle class, AbstractHandle, and a base class for the control \
elements, ControlElement. I developed an handle based on the actual AppletHandle, \
DesktopHandle, and the control elements for the usual operations.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It isn't finished. It's missing the touch events management \
(which, however, it's hard for me to do, 'cause i don't have any touch \
screen device) and a better drag and drop system between containments. I'd like, \
however, to know what you think about what i've done, especially about the \
architecture.
What's here works, though.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/plasma/CMakeLists.txt <span style="color: \
grey">(1170608)</span></li>
<li>trunk/KDE/kdelibs/plasma/applet.h <span style="color: \
grey">(1170608)</span></li>
<li>trunk/KDE/kdelibs/plasma/applet.cpp <span style="color: \
grey">(1170608)</span></li>
<li>trunk/KDE/kdelibs/plasma/containment.h <span style="color: \
grey">(1170608)</span></li>
<li>trunk/KDE/kdelibs/plasma/containment.cpp <span style="color: \
grey">(1170608)</span></li>
<li>trunk/KDE/kdelibs/plasma/extenders/extender.cpp <span style="color: \
grey">(1170608)</span></li>
<li>trunk/KDE/kdelibs/plasma/extenders/extenderitem.cpp <span style="color: \
grey">(1170608)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/abstracthandle.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/abstracthandle.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/applet_p.h <span style="color: \
grey">(1170608)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/applethandle.cpp <span style="color: \
grey">(1170608)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/applethandle_p.h <span style="color: \
grey">(1170608)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/configurecontrol.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/configurecontrol.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/containment_p.h <span style="color: \
grey">(1170608)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/controlelement.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/controlelement.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/controlelement_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/desktophandle.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/desktophandle.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/maximizecontrol.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/maximizecontrol.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/movecontrol.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/movecontrol.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/removecontrol.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/removecontrol.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/resizecontrol.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/resizecontrol.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/rotatecontrol.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/rotatecontrol.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5155/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic