'Re: Review Request: New Applet handle system'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: New Applet handle system
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2010-09-01 15:38:41
Message-ID: 20100901153841.11919.30018 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On 2010-08-31 11:27:51, Marco Martin wrote:
> > trunk/KDE/kdelibs/plasma/private/abstracthandle.h, line 67
> > <http://reviewboard.kde.org/r/5155/diff/1/?file=34663#file34663line67>
> > 
> > what is the exact use case for this function?
> 
> Giulio Camuffo wrote:
> It does all the cleanings before destroying the handle. If you're asking me why i'm \
> not doing them in the destructor then i'll say ask Kevin Ottens about it. I took \
> that from the actual AppletHandle and i think there is a reason if there is it.

probablythere was the need to do it also somewhere else at some point.
it shouldn't be in the api i think tough

> On 2010-08-31 11:27:51, Marco Martin wrote:
> > trunk/KDE/kdelibs/plasma/private/abstracthandle.h, line 89
> > <http://reviewboard.kde.org/r/5155/diff/1/?file=34663#file34663line89>
> > 
> > isn't possible for the handle discover it by itself with hoverevents?
> 
> Giulio Camuffo wrote:
> I'd say yes, but another time: why is it in AppletHandle? Maybe the Containment \
> needs it.

for those things the thing to do is:
hide everything.
then see who still needs it
and see if it can be done in some other way, wen everything else fails, export to \
api, but only as a last chance :)

> On 2010-08-31 11:27:51, Marco Martin wrote:
> > trunk/KDE/kdelibs/plasma/private/abstracthandle.h, line 123
> > <http://reviewboard.kde.org/r/5155/diff/1/?file=34663#file34663line123>
> > 
> > this is kinda necessary but i would love to move it out of the pubic api
> 
> Giulio Camuffo wrote:
> Since it is called by the control elements i moved it in ControlElement, as a \
> protected method.

yeah, in ControlElement makes more sense to me

- Marco

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5155/#review7311
-----------------------------------------------------------

On 2010-08-26 10:30:18, Giulio Camuffo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5155/
> -----------------------------------------------------------
> 
> (Updated 2010-08-26 10:30:18)
> 
> 
> Review request for Plasma and Aaron Seigo.
> 
> 
> Summary
> -------
> 
> This is a rewamp of the Applet handle system. Through its modular architecture it \
> easily allows modifications and reuse of code. 
> It features a base Handle class, AbstractHandle, and a base class for the control \
> elements, ControlElement. I developed an handle based on the actual AppletHandle, \
> DesktopHandle, and the control elements for the usual operations. 
> 
> Diffs
> -----
> 
> trunk/KDE/kdelibs/plasma/CMakeLists.txt 1168271 
> trunk/KDE/kdelibs/plasma/applet.h 1168271 
> trunk/KDE/kdelibs/plasma/applet.cpp 1168271 
> trunk/KDE/kdelibs/plasma/containment.h 1168271 
> trunk/KDE/kdelibs/plasma/containment.cpp 1168271 
> trunk/KDE/kdelibs/plasma/extenders/extender.cpp 1168271 
> trunk/KDE/kdelibs/plasma/extenders/extenderitem.cpp 1168271 
> trunk/KDE/kdelibs/plasma/private/abstracthandle.h PRE-CREATION 
> trunk/KDE/kdelibs/plasma/private/abstracthandle.cpp PRE-CREATION 
> trunk/KDE/kdelibs/plasma/private/applet_p.h 1168271 
> trunk/KDE/kdelibs/plasma/private/applethandle.cpp 1168271 
> trunk/KDE/kdelibs/plasma/private/applethandle_p.h 1168271 
> trunk/KDE/kdelibs/plasma/private/configurecontrol.h PRE-CREATION 
> trunk/KDE/kdelibs/plasma/private/configurecontrol.cpp PRE-CREATION 
> trunk/KDE/kdelibs/plasma/private/containment_p.h 1168271 
> trunk/KDE/kdelibs/plasma/private/controlelement.h PRE-CREATION 
> trunk/KDE/kdelibs/plasma/private/controlelement.cpp PRE-CREATION 
> trunk/KDE/kdelibs/plasma/private/controlelement_p.h PRE-CREATION 
> trunk/KDE/kdelibs/plasma/private/desktophandle.h PRE-CREATION 
> trunk/KDE/kdelibs/plasma/private/desktophandle.cpp PRE-CREATION 
> trunk/KDE/kdelibs/plasma/private/maximizecontrol.h PRE-CREATION 
> trunk/KDE/kdelibs/plasma/private/maximizecontrol.cpp PRE-CREATION 
> trunk/KDE/kdelibs/plasma/private/movecontrol.h PRE-CREATION 
> trunk/KDE/kdelibs/plasma/private/movecontrol.cpp PRE-CREATION 
> trunk/KDE/kdelibs/plasma/private/removecontrol.h PRE-CREATION 
> trunk/KDE/kdelibs/plasma/private/removecontrol.cpp PRE-CREATION 
> trunk/KDE/kdelibs/plasma/private/resizecontrol.h PRE-CREATION 
> trunk/KDE/kdelibs/plasma/private/resizecontrol.cpp PRE-CREATION 
> trunk/KDE/kdelibs/plasma/private/rotatecontrol.h PRE-CREATION 
> trunk/KDE/kdelibs/plasma/private/rotatecontrol.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/5155/diff
> 
> 
> Testing
> -------
> 
> It isn't finished. It's missing the touch events management (which, however, it's \
> hard to me to do, 'cause i don't have any touch screen device) and a better drag \
> and drop system between containments. I'd like, however, to know what you think \
> about what i've done, especially about the architecture. 
> What's here works, though.
> 
> 
> Thanks,
> 
> Giulio
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/5155/">http://reviewboard.kde.org/r/5155/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On August 31st, 2010, 11:27 a.m., <b>Marco \
Martin</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="/r/5155/diff/1/?file=34663#file34663line67" style="color: black; font-weight: \
bold; text-decoration: \
underline;">trunk/KDE/kdelibs/plasma/private/abstracthandle.h</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">class AbstractHandle : public QGraphicsObject</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">67</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="k">virtual</span> <span class="kt">void</span> <span \
class="n">detachWidget</span><span class="p">();</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">what is the exact use \
case for this function?</pre>  </blockquote>

 <p>On September 1st, 2010, 3:13 p.m., <b>Giulio Camuffo</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It does all the \
cleanings before destroying the handle. If you&#39;re asking me why i&#39;m not doing \
them in the destructor then i&#39;ll say ask Kevin Ottens about it. I took that from \
the actual AppletHandle and i think there is a reason if there is it.</pre>  \
</blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">probablythere was the need to do it also somewhere else at some point. \
it shouldn&#39;t be in the api i think tough</pre> <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On August 31st, 2010, 11:27 a.m., <b>Marco \
Martin</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="/r/5155/diff/1/?file=34663#file34663line89" style="color: black; font-weight: \
bold; text-decoration: \
underline;">trunk/KDE/kdelibs/plasma/private/abstracthandle.h</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">class AbstractHandle : public QGraphicsObject</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">89</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="k">virtual</span> <span class="kt">void</span> <span \
class="n">setHoverPos</span><span class="p">(</span><span class="k">const</span> \
<span class="n">QPointF</span> <span class="o">&amp;</span><span \
class="n">hoverPos</span><span class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">isn&#39;t possible for \
the handle discover it by itself with hoverevents?</pre>  </blockquote>

 <p>On September 1st, 2010, 3:14 p.m., <b>Giulio Camuffo</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I&#39;d say yes, but \
another time: why is it in AppletHandle? Maybe the Containment needs it.</pre>  \
</blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">for those \
things the thing to do is: hide everything.
then see who still needs it
and see if it can be done in some other way, wen everything else fails, export to \
api, but only as a last chance :)</pre> <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On August 31st, 2010, 11:27 a.m., <b>Marco \
Martin</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="/r/5155/diff/1/?file=34663#file34663line123" style="color: black; font-weight: \
bold; text-decoration: \
underline;">trunk/KDE/kdelibs/plasma/private/abstracthandle.h</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">class AbstractHandle : public QGraphicsObject</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">123</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">bool</span> <span class="n">leaveCurrentView</span><span \
class="p">(</span><span class="k">const</span> <span class="n">QPoint</span> <span \
class="o">&amp;</span><span class="n">pos</span><span class="p">)</span> <span \
class="k">const</span><span class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this is kinda necessary \
but i would love to move it out of the pubic api</pre>  </blockquote>

 <p>On September 1st, 2010, 3:15 p.m., <b>Giulio Camuffo</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since it is called by \
the control elements i moved it in ControlElement, as a protected method.</pre>  \
</blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yeah, in \
ControlElement makes more sense to me</pre> <br />

<p>- Marco</p>

<br />
<p>On August 26th, 2010, 10:30 a.m., Giulio Camuffo wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Aaron Seigo.</div>
<div>By Giulio Camuffo.</div>

<p style="color: grey;"><i>Updated 2010-08-26 10:30:18</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is a rewamp of the Applet handle system. Through its modular \
architecture it easily allows modifications and reuse of code.

It features a base Handle class, AbstractHandle, and a base class for the control \
elements, ControlElement. I developed an handle based on the actual AppletHandle, \
DesktopHandle, and the control elements for the usual operations.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It isn&#39;t finished. It&#39;s missing the touch events management \
(which, however, it&#39;s hard to me to do, &#39;cause i don&#39;t have any touch \
screen device) and a better drag and drop system between containments. I&#39;d like, \
however, to know what you think about what i&#39;ve done, especially about the \
architecture.

What&#39;s here works, though.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/KDE/kdelibs/plasma/CMakeLists.txt <span style="color: \
grey">(1168271)</span></li>

 <li>trunk/KDE/kdelibs/plasma/applet.h <span style="color: \
grey">(1168271)</span></li>

 <li>trunk/KDE/kdelibs/plasma/applet.cpp <span style="color: \
grey">(1168271)</span></li>

 <li>trunk/KDE/kdelibs/plasma/containment.h <span style="color: \
grey">(1168271)</span></li>

 <li>trunk/KDE/kdelibs/plasma/containment.cpp <span style="color: \
grey">(1168271)</span></li>

 <li>trunk/KDE/kdelibs/plasma/extenders/extender.cpp <span style="color: \
grey">(1168271)</span></li>

 <li>trunk/KDE/kdelibs/plasma/extenders/extenderitem.cpp <span style="color: \
grey">(1168271)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/abstracthandle.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/abstracthandle.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/applet_p.h <span style="color: \
grey">(1168271)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/applethandle.cpp <span style="color: \
grey">(1168271)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/applethandle_p.h <span style="color: \
grey">(1168271)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/configurecontrol.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/configurecontrol.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/containment_p.h <span style="color: \
grey">(1168271)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/controlelement.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/controlelement.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/controlelement_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/desktophandle.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/desktophandle.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/maximizecontrol.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/maximizecontrol.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/movecontrol.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/movecontrol.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/removecontrol.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/removecontrol.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/resizecontrol.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/resizecontrol.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/rotatecontrol.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdelibs/plasma/private/rotatecontrol.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/5155/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 