[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: kdreview: dictionary runner;
From:       "Jason A. Donenfeld" <Jason () zx2c4 ! com>
Date:       2010-08-29 21:54:28
Message-ID: AANLkTimuJ7G2AraZ_6dUEcxSCHW9B4i80WiJqg96XFRY () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Sat, Aug 28, 2010 at 17:10, Aaron J. Seigo <aseigo@kde.org> wrote:
>
> well, we can fix that. if nothing else, this was a great exercise in
> discovering what needs to be improved exactly, and how :)
>
> match is given the RunnerContext on each invocation. that RunnerContext may
> become invalid at any time, though, so there is no "current" or "the"
> RunnerContext in this sense.
>
> a runner could create a separate QObject subclass for each call that holds
> onto the RunnerContext passed it as a member variable, and that object
> could
> do exactly as you describe (and then delete itself when finished).



I'm going to re-factor the dictionary runner to use this approach so that
the new setReentrant(true) switch will have something to test against, for
whoever ends up implementing that.

[Attachment #5 (text/html)]

<div class="gmail_quote">On Sat, Aug 28, 2010 at 17:10, Aaron J. Seigo <span \
dir="ltr">&lt;<a href="mailto:aseigo@kde.org">aseigo@kde.org</a>&gt;</span> \
wrote:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex;"> well, we can fix that. if nothing else, this was a great \
exercise in<br> discovering what needs to be improved exactly, and how :)<br>
<div class="im"><br>
</div>match is given the RunnerContext on each invocation. that RunnerContext may<br>
become invalid at any time, though, so there is no &quot;current&quot; or \
&quot;the&quot;<br> RunnerContext in this sense.<br>
<br>
a runner could create a separate QObject subclass for each call that holds<br>
onto the RunnerContext passed it as a member variable, and that object could<br>
do exactly as you describe (and then delete itself when \
finished).</blockquote><div><br></div><div><br></div><div>I&#39;m going to re-factor \
the dictionary runner to use this approach so that the new setReentrant(true) switch \
will have something to test against, for whoever ends up implementing that.</div> \
</div>



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]