[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Start Present windows by ctrl+left click on a
From: "Artur de Souza \(MoRpHeUz\)" <asouza () kde ! org>
Date: 2010-08-28 14:36:58
Message-ID: 20100828143658.9923.20168 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5035/#review7249
-----------------------------------------------------------
Besides being a "hidden feature" it seems nice. I'm not sure how would be o=
ur "policy" for hidden features but from my point of view seems to be a nic=
e feature. Just to do an analogy: imho it's as hidden as the "effects on th=
e corner of the screen" feature, but with the advantage that it's in a plac=
e that already takes care of virtual desktops.
- Artur
On 2010-08-28 07:49:57, Martin Gr=C3=A4=C3=9Flin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5035/
> -----------------------------------------------------------
> =
> (Updated 2010-08-28 07:49:57)
> =
> =
> Review request for Plasma, Aaron Seigo and Marco Martin.
> =
> =
> Summary
> -------
> =
> This patch adds support to pager to trigger the present windows effect fo=
r the desktop the user clicks on when holding ctrl. This is similar to what=
we have when clicking on a tasks group when ctrl is hold.
> =
> I'm not sure if this is a too hidden feature, but I consider it as could =
be useful and consistent with the tasks applet.
> =
> =
> Diffs
> -----
> =
> trunk/KDE/kdebase/workspace/plasma/desktop/applets/pager/pager.cpp 1163=
977 =
> =
> Diff: http://reviewboard.kde.org/r/5035/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Martin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5035/">http://reviewboard.kde.org/r/5035/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Besides being a \
"hidden feature" it seems nice. I'm not sure how would be our \
"policy" for hidden features but from my point of view seems to be a nice \
feature. Just to do an analogy: imho it's as hidden as the "effects on the \
corner of the screen" feature, but with the advantage that it's in a place \
that already takes care of virtual desktops.</pre> <br />
<p>- Artur</p>
<br />
<p>On August 28th, 2010, 7:49 a.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Aaron Seigo and Marco Martin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated 2010-08-28 07:49:57</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds support to pager to trigger the present windows effect \
for the desktop the user clicks on when holding ctrl. This is similar to what we have \
when clicking on a tasks group when ctrl is hold.
I'm not sure if this is a too hidden feature, but I consider it as could be \
useful and consistent with the tasks applet.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdebase/workspace/plasma/desktop/applets/pager/pager.cpp <span \
style="color: grey">(1163977)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5035/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic