[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request: New Applet handle system
From: "Giulio Camuffo" <giuliocamuffo () gmail ! com>
Date: 2010-08-26 10:30:18
Message-ID: 20100826103018.9564.88118 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5155/
-----------------------------------------------------------
Review request for Plasma and Aaron Seigo.
Summary
-------
This is a rewamp of the Applet handle system. Through its modular architect=
ure it easily allows modifications and reuse of code.
It features a base Handle class, AbstractHandle, and a base class for the c=
ontrol elements, ControlElement. I developed an handle based on the actual =
AppletHandle, DesktopHandle, and the control elements for the usual operati=
ons.
Diffs
-----
trunk/KDE/kdelibs/plasma/CMakeLists.txt 1168271 =
trunk/KDE/kdelibs/plasma/applet.h 1168271 =
trunk/KDE/kdelibs/plasma/applet.cpp 1168271 =
trunk/KDE/kdelibs/plasma/containment.h 1168271 =
trunk/KDE/kdelibs/plasma/containment.cpp 1168271 =
trunk/KDE/kdelibs/plasma/extenders/extender.cpp 1168271 =
trunk/KDE/kdelibs/plasma/extenders/extenderitem.cpp 1168271 =
trunk/KDE/kdelibs/plasma/private/abstracthandle.h PRE-CREATION =
trunk/KDE/kdelibs/plasma/private/abstracthandle.cpp PRE-CREATION =
trunk/KDE/kdelibs/plasma/private/applet_p.h 1168271 =
trunk/KDE/kdelibs/plasma/private/applethandle.cpp 1168271 =
trunk/KDE/kdelibs/plasma/private/applethandle_p.h 1168271 =
trunk/KDE/kdelibs/plasma/private/configurecontrol.h PRE-CREATION =
trunk/KDE/kdelibs/plasma/private/configurecontrol.cpp PRE-CREATION =
trunk/KDE/kdelibs/plasma/private/containment_p.h 1168271 =
trunk/KDE/kdelibs/plasma/private/controlelement.h PRE-CREATION =
trunk/KDE/kdelibs/plasma/private/controlelement.cpp PRE-CREATION =
trunk/KDE/kdelibs/plasma/private/controlelement_p.h PRE-CREATION =
trunk/KDE/kdelibs/plasma/private/desktophandle.h PRE-CREATION =
trunk/KDE/kdelibs/plasma/private/desktophandle.cpp PRE-CREATION =
trunk/KDE/kdelibs/plasma/private/maximizecontrol.h PRE-CREATION =
trunk/KDE/kdelibs/plasma/private/maximizecontrol.cpp PRE-CREATION =
trunk/KDE/kdelibs/plasma/private/movecontrol.h PRE-CREATION =
trunk/KDE/kdelibs/plasma/private/movecontrol.cpp PRE-CREATION =
trunk/KDE/kdelibs/plasma/private/removecontrol.h PRE-CREATION =
trunk/KDE/kdelibs/plasma/private/removecontrol.cpp PRE-CREATION =
trunk/KDE/kdelibs/plasma/private/resizecontrol.h PRE-CREATION =
trunk/KDE/kdelibs/plasma/private/resizecontrol.cpp PRE-CREATION =
trunk/KDE/kdelibs/plasma/private/rotatecontrol.h PRE-CREATION =
trunk/KDE/kdelibs/plasma/private/rotatecontrol.cpp PRE-CREATION =
Diff: http://reviewboard.kde.org/r/5155/diff
Testing
-------
It isn't finished. It's missing the touch events management (which, however=
, it's hard to me to do, 'cause i don't have any touch screen device) and a=
better drag and drop system between containments. I'd like, however, to kn=
ow what you think about what i've done, especially about the architecture.
What's here works, though.
Thanks,
Giulio
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5155/">http://reviewboard.kde.org/r/5155/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Aaron Seigo.</div>
<div>By Giulio Camuffo.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is a rewamp of the Applet handle system. Through its modular \
architecture it easily allows modifications and reuse of code.
It features a base Handle class, AbstractHandle, and a base class for the control \
elements, ControlElement. I developed an handle based on the actual AppletHandle, \
DesktopHandle, and the control elements for the usual operations.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It isn't finished. It's missing the touch events management \
(which, however, it's hard to me to do, 'cause i don't have any touch \
screen device) and a better drag and drop system between containments. I'd like, \
however, to know what you think about what i've done, especially about the \
architecture.
What's here works, though.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/plasma/CMakeLists.txt <span style="color: \
grey">(1168271)</span></li>
<li>trunk/KDE/kdelibs/plasma/applet.h <span style="color: \
grey">(1168271)</span></li>
<li>trunk/KDE/kdelibs/plasma/applet.cpp <span style="color: \
grey">(1168271)</span></li>
<li>trunk/KDE/kdelibs/plasma/containment.h <span style="color: \
grey">(1168271)</span></li>
<li>trunk/KDE/kdelibs/plasma/containment.cpp <span style="color: \
grey">(1168271)</span></li>
<li>trunk/KDE/kdelibs/plasma/extenders/extender.cpp <span style="color: \
grey">(1168271)</span></li>
<li>trunk/KDE/kdelibs/plasma/extenders/extenderitem.cpp <span style="color: \
grey">(1168271)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/abstracthandle.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/abstracthandle.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/applet_p.h <span style="color: \
grey">(1168271)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/applethandle.cpp <span style="color: \
grey">(1168271)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/applethandle_p.h <span style="color: \
grey">(1168271)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/configurecontrol.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/configurecontrol.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/containment_p.h <span style="color: \
grey">(1168271)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/controlelement.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/controlelement.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/controlelement_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/desktophandle.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/desktophandle.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/maximizecontrol.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/maximizecontrol.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/movecontrol.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/movecontrol.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/removecontrol.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/removecontrol.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/resizecontrol.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/resizecontrol.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/rotatecontrol.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/private/rotatecontrol.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5155/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic