--===============1310643638== Content-Type: multipart/alternative; boundary="===============4178265826070155096==" --===============4178265826070155096== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2010-08-23 09:00:48, Marco Martin wrote: > > this very patch appeared here for several times already. > > and as usual, the question is: what real value gives over auto hiding t= he text when there is not enough space? > = > Markus Slopianka wrote: > If this patch works with the other one that implements launcher suppo= rt, a Mac OS X-like Dock (AFAIK it's similar in Win7) can be implemented wi= thout the need to get 3rd party widgets. > With a Dock-like setup I wouldn't want text other than tooltips. > = > Beat Wolf wrote: > i would actually agree on adding it from the feedback i get when i sh= ow kde to people used to windows. it's one of the first things they ask for. > = > Aaron Seigo wrote: > the number of such features that have appeared over the years is imme= nse, and always people ask for those features ... as long as they are new i= n Windows. there is no point in chasing taillights just to chase taillights= . if the idea is a good one, let's do it; if it isn't, let's not. > = > Beat Wolf wrote: > sure. i was just mentioning it because i for myself think its a good = idea and other people want it, so from my point of view if the patch has a = good quality, and it's actually using a feature that is there anyway, why n= ot have it. > But i see the other point of views too and all have their merit i thi= nk. > = > Todd wrote: > I think that the question is not so much a question of why we shouldn= 't have titles in the task manager, the question is why we need them. With= grouping and the ability in 4.5 to change between grouped windows by click= ing on their thumbnail, at least for me titles are just wasted space. I un= derstand that for people without compositing they are needed, and some peop= le may still prefer them, but personally they don't contribute anything, an= d they are huge relative to just the icons. > = > I agree that the the current configuration interface for the task man= ager is getting a bit crowded. However, there is a way to add the feature = without increasing the complexity of the dialog. Currently there are three= grouping options: "Do not group", "Manually", and "By Program Name". Ther= e is also an checkox "Only when taskbar is full". The problem is that this= option is only meaningful in "By Program Name" mode, and in fact the check= box is disabled when the other two modes. So I would suggest getting rid o= f the checkbox and adding a fourth option in the dropdown "When taskbar is = full", or something along those lines. = > = > Also, since plasma supports multiple categories in the configuration = dialog, it may be worthwhile splitting the current options into categories. > = > Marco Martin wrote: > > With grouping and the ability in 4.5 to change between grouped wind= ows by clicking on their thumbnail, at least for me titles are just wasted = space. > = > well, i think in this case is really fake "wasted space" because i wo= uld agree if the text would let to have less icons in the taskbar. > but since when there is not enough room the text gets disabled automa= tically, this is a no issue. > without that i really don't see use cases except making it look like = windows > = > Todd wrote: > It isn't fake wasted space, there is still a bunch of text on there t= hat fills up the area while contributing nothing to me. I don't think it l= ooks good. This has nothing whatsoever to do with making it look like wind= ows, I couldn't care less what windows does. It has to do with not making = it look cluttered and inelegant. = > = > The text also contributes to the resizing of the panel, making the pa= nel much larger than it has to be. I could, of course, force the panel to = be small, but that works against me when I do have a lot of open windows, s= ince it drastically limits the number of windows I can work with easily. = > = > Further, when the text is removed the tasks still expand to fill the = available space, which looks really bad in my opinion. It makes sense when= you want to show the text is hidden, but not when you don't want to deal w= ith the text at all. "contributing nothing to me" * a larger target (Fitt's "Law") * disambiguation from other similar items that may not matter to you, and i fully grant that. it matters to others, a= nd we (the maintainers of this item) do not see enough value in option to t= urn the items into icons-only to include it in the tasks plasmoid directly. i have, however, already described a way that you (and whomever else) can a= ccomplish your goals. we aren't exclusive, plasma has been designed to allo= w differences of opinion, differences of goals. others have taken advantage= of this with stasks, fancytasks, etc. you can do the same without having t= o convince anyone or ask anyone's permission. so instead of continuing this= conversation which is going to lead nowhere other than to find out what we= already know (namely: we disagree on this matter), let's get back to hacki= ng. as soon as your window listing plasmoid is ready (you can develop it in= playground until then), we can move it into kdereview and then move it on = into the appropriate module. cheers ... - Aaron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5078/#review7162 ----------------------------------------------------------- On 2010-08-22 13:52:33, Bj=C3=B6rn Ruberg wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/5078/ > ----------------------------------------------------------- > = > (Updated 2010-08-22 13:52:33) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > This patch adds the option to put the taskbar in an icon-only mode - simi= lar as in Windows 7 . This is an much requested feature in bugzilla. > It is fairly simple and just using features already existing in the code,= adding an m_showIconOnly member to the layout and the abstractitem plus th= e adaption of the config ui. > = > = > This addresses bug 159480. > https://bugs.kde.org/show_bug.cgi?id=3D159480 > = > = > Diffs > ----- > = > /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasksConfig.u= i 1166313 = > /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp 116= 6313 = > /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayou= t.h 1166313 = > /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayou= t.cpp 1166313 = > /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaski= tem.h 1166313 = > /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaski= tem.cpp 1166313 = > /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem= .h 1166313 = > /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem= .cpp 1166313 = > = > Diff: http://reviewboard.kde.org/r/5078/diff > = > = > Testing > ------- > = > Moved panel around and made sure it works. Looks actually pretty good thi= s icon-only mode! > = > = > Thanks, > = > Bj=C3=B6rn > = > --===============4178265826070155096== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde= .org/r/5078/

On August 23rd, 2010, 9 a.m., Marco Martin<= /b> wrote:

this very=
 patch appeared here for several times already.
and as usual, the question is: what real value gives over auto hiding the t=
ext when there is not enough space?

On August 23rd, 2010, 9:53 a.m., Markus Slopianka wrote:

If this p=
atch works with the other one that implements launcher support, a Mac OS X-=
like Dock (AFAIK it's similar in Win7) can be implemented without the n=
eed to get 3rd party widgets.
With a Dock-like setup I wouldn't want text other than tooltips.

On August 23rd, 2010, 9:57 a.m., Beat Wolf wrote:

i would a=
ctually agree on adding it from the feedback i get when i show kde to peopl=
e used to windows. it's one of the first things they ask for.

On August 23rd, 2010, 10:52 p.m., Aaron Seigo wrote:

the numbe=
r of such features that have appeared over the years is immense, and always=
 people ask for those features ... as long as they are new in Windows. ther=
e is no point in chasing taillights just to chase taillights. if the idea i=
s a good one, let's do it; if it isn't, let's not.

On August 24th, 2010, 8:02 a.m., Beat Wolf wrote:

sure. i w=
as just mentioning it because i for myself think its a good idea and other =
people want it, so from my point of view if the patch has a good quality, a=
nd it's actually using a feature that is there anyway, why not have it.
But i see the other point of views too and all have their merit i think.

On August 24th, 2010, 2:25 p.m., Todd wrote:

I think t=
hat the question is not so much a question of why we shouldn't have tit=
les in the task manager, the question is why we need them.  With grouping a=
nd the ability in 4.5 to change between grouped windows by clicking on thei=
r thumbnail, at least for me titles are just wasted space.  I understand th=
at for people without compositing they are needed, and some people may stil=
l prefer them, but personally they don't contribute anything, and they =
are huge relative to just the icons.

I agree that the the current configuration interface for the task manager i=
s getting a bit crowded.  However, there is a way to add the feature withou=
t increasing the complexity of the dialog.  Currently there are three group=
ing options: "Do not group", "Manually", and "By P=
rogram Name".  There is also an checkox "Only when taskbar is ful=
l".  The problem is that this option is only meaningful in "By Pr=
ogram Name" mode, and in fact the checkbox is disabled when the other =
two modes.  So I would suggest getting rid of the checkbox and adding a fou=
rth option in the dropdown "When taskbar is full", or something a=
long those lines. =


Also, since plasma supports multiple categories in the configuration dialog=
, it may be worthwhile splitting the current options into categories.

On August 24th, 2010, 2:32 p.m., Marco Martin wrote:

> With=
 grouping and the ability in 4.5 to change between grouped windows by click=
ing on their thumbnail, at least for me titles are just wasted space.

well, i think in this case is really fake "wasted space" because =
i would agree if the text would let to have less icons in the taskbar.
but since when there is not enough room the text gets disabled automaticall=
y, this is a no issue.
without that i really don't see use cases except making it look like wi=
ndows

On August 24th, 2010, 4:17 p.m., Todd wrote:

It isn=
9;t fake wasted space, there is still a bunch of text on there that fills u=
p the area while contributing nothing to me.  I don't think it looks go=
od.  This has nothing whatsoever to do with making it look like windows, I =
couldn't care less what windows does.  It has to do with not making it =
look cluttered and inelegant.  =


The text also contributes to the resizing of the panel, making the panel mu=
ch larger than it has to be.  I could, of course, force the panel to be sma=
ll, but that works against me when I do have a lot of open windows, since i=
t drastically limits the number of windows I can work with easily.  =


Further, when the text is removed the tasks still expand to fill the availa=
ble space, which looks really bad in my opinion.  It makes sense when you w=
ant to show the text is hidden, but not when you don't want to deal wit=
h the text at all.
"contr=
ibuting nothing to me"

* a larger target (Fitt's "Law")
* disambiguation from other similar items

that may not matter to you, and i fully grant that. it matters to others, a=
nd we (the maintainers of this item) do not see enough value in option to t=
urn the items into icons-only to include it in the tasks plasmoid directly.

i have, however, already described a way that you (and whomever else) can a=
ccomplish your goals. we aren't exclusive, plasma has been designed to =
allow differences of opinion, differences of goals. others have taken advan=
tage of this with stasks, fancytasks, etc. you can do the same without havi=
ng to convince anyone or ask anyone's permission. so instead of continu=
ing this conversation which is going to lead nowhere other than to find out=
 what we already know (namely: we disagree on this matter), let's get b=
ack to hacking. as soon as your window listing plasmoid is ready (you can d=
evelop it in playground until then), we can move it into kdereview and then=
 move it on into the appropriate module. cheers ...

- Aaron


On August 22nd, 2010, 1:52 p.m., Bj=C3=B6rn Ruberg wrote:

Review request for Plasma.
By Bj=C3=B6rn Ruberg.

Updated 2010-08-22 13:52:33

Descripti= on 

This patch adds the option to put the taskbar in an icon-onl=
y mode - similar as in Windows 7 . This is an much requested feature in bug=
zilla.
It is fairly simple and just using features already existing in the code, a=
dding an m_showIconOnly member to the layout and the abstractitem plus the =
adaption of the config ui.

Testing <= /h1> 
Moved panel around and made sure it works. Looks actually pr=
etty good this icon-only mode!
Bugs: 159480

Diffs=

  • /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasksConfig.= ui (1166313)
  • /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp (1166313)
  • /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayo= ut.h (1166313)
  • /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayo= ut.cpp (1166313)
  • /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttask= item.h (1166313)
  • /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttask= item.cpp (1166313)
  • /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupite= m.h (1166313)
  • /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupite= m.cpp (1166313)

View Diff
--===============4178265826070155096==-- --===============1310643638== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1310643638==--