[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Extend FolderView::configChanged() to reload
From:       Sebastian =?iso-8859-1?q?K=FCgler?= <sebas () kde ! org>
Date:       2010-08-23 13:33:31
Message-ID: 201008231533.32118.sebas () kde ! org
[Download RAW message or body]

On Sunday 22 August 2010 19:44:36 Harald Sitter wrote:
> /trunk/KDE/kdebase/apps/plasma/applets/folderview/folderview.cpp  (Diff
> revision 7) void FolderView::init()
>   444
>      const QList<int> iconSizes = QList<int>() << 16 << 22 << 32 << 48 <<
> 64 << 128; This is duplicated with configAccepted!
> 
> Due to what this variable actual represents I do not find it wise to have
> two occurances of the same list. Instead it should be turned into
> something static const or a macro if absolutely necessary.

Look at KIconLoader instead of hardcoding these values.
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]