'Re: Review Request: Add "Show Icon only" option to the tasks applet'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Add "Show Icon only" option to the tasks applet
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2010-08-23 9:00:46
Message-ID: 20100823090046.12469.73423 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5078/#review7162
-----------------------------------------------------------

this very patch appeared here for several times already.
and as usual, the question is: what real value gives over auto hiding the text when \
there is not enough space?

- Marco

On 2010-08-22 13:52:33, Björn Ruberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5078/
> -----------------------------------------------------------
> 
> (Updated 2010-08-22 13:52:33)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch adds the option to put the taskbar in an icon-only mode - similar as in \
> Windows 7 . This is an much requested feature in bugzilla. It is fairly simple and \
> just using features already existing in the code, adding an m_showIconOnly member \
> to the layout and the abstractitem plus the adaption of the config ui. 
> 
> This addresses bug 159480.
> https://bugs.kde.org/show_bug.cgi?id=159480
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasksConfig.ui 1166313 
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp 1166313 
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.h 1166313 
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.cpp \
>                 1166313 
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.h \
>                 1166313 
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.cpp \
>                 1166313 
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.h 1166313 
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.cpp 1166313 \
>  
> Diff: http://reviewboard.kde.org/r/5078/diff
> 
> 
> Testing
> -------
> 
> Moved panel around and made sure it works. Looks actually pretty good this \
> icon-only mode! 
> 
> Thanks,
> 
> Björn
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/5078/">http://reviewboard.kde.org/r/5078/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this very patch appeared \
here for several times already. and as usual, the question is: what real value gives \
over auto hiding the text when there is not enough space?</pre>  <br />

<p>- Marco</p>

<br />
<p>On August 22nd, 2010, 1:52 p.m., Björn Ruberg wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Björn Ruberg.</div>

<p style="color: grey;"><i>Updated 2010-08-22 13:52:33</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds the option to put the taskbar in an icon-only mode - \
similar as in Windows 7 . This is an much requested feature in bugzilla. It is fairly \
simple and just using features already existing in the code, adding an m_showIconOnly \
member to the layout and the abstractitem plus the adaption of the config ui.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Moved panel around and made sure it works. Looks actually pretty good \
this icon-only mode!</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=159480">159480</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasksConfig.ui <span \
style="color: grey">(1166313)</span></li>

 <li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp <span \
style="color: grey">(1166313)</span></li>

 <li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.h <span \
style="color: grey">(1166313)</span></li>

 <li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.cpp \
<span style="color: grey">(1166313)</span></li>

 <li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.h \
<span style="color: grey">(1166313)</span></li>

 <li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.cpp \
<span style="color: grey">(1166313)</span></li>

 <li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.h <span \
style="color: grey">(1166313)</span></li>

 <li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.cpp \
<span style="color: grey">(1166313)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/5078/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 