[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Launcher support for libtaskmanager
From: "Anton Kreuzkamp" <akreuzkamp () web ! de>
Date: 2010-08-22 10:30:38
Message-ID: 20100822103038.739.57387 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-07-13 20:53:40, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp, lines 264-269
> > <http://reviewboard.kde.org/r/4585/diff/3/?file=30674#file30674line264>
> >
> > why are launchers with no window instances removed from the member list?
isVisible() returns true if there's no window instance, so it get removed if there is one.
- Anton
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4585/#review6545
-----------------------------------------------------------
On 2010-07-10 18:21:39, Anton Kreuzkamp wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4585/
> -----------------------------------------------------------
>
> (Updated 2010-07-10 18:21:39)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Adds support for Windows 7 like launchers in libtaskmanager.
> (I'm on holliday from 12th July until 1st August so I will not be able to reply during this time.)
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/libs/taskmanager/taskitem.h 1148442
> /trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp 1148442
> /trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.h 1148442
> /trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/programgroupingstrategy.cpp 1148442
> /trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.cpp PRE-CREATION
> /trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.h PRE-CREATION
> /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp 1148442
> /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h 1148442
> /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.h 1148442
> /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractsortingstrategy.cpp 1148442
> /trunk/KDE/kdebase/workspace/libs/taskmanager/CMakeLists.txt 1148442
>
> Diff: http://reviewboard.kde.org/r/4585/diff
>
>
> Testing
> -------
>
> Tested with a small test-applett and everything works.
>
>
> Thanks,
>
> Anton
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4585/">http://reviewboard.kde.org/r/4585/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 13th, 2010, 8:53 p.m., <b>Aaron Seigo</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/4585/diff/3/?file=30674#file30674line264" style="color: black; font-weight: \
bold; text-decoration: \
underline;">/trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
TaskGroup::remove(AbstractGroupableItem *item)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">264</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">member</span><span \
class="o">-></span><span class="n">isLauncherItem</span><span class="p">())</span> \
<span class="p">{</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">265</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">LauncherItem</span> <span class="o">*</span><span \
class="n">item</span> <span class="o">=</span> <span \
class="n">qobject_cast</span><span class="o"><</span><span \
class="n">LauncherItem</span><span class="o">*></span><span \
class="p">(</span><span class="n">member</span><span class="p">);</span></pre></td> \
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">266</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span class="o">!</span><span \
class="n">item</span><span class="o">-></span><span \
class="n">isVisible</span><span class="p">())</span> <span \
class="p">{</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">267</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">list</span><span class="p">.</span><span \
class="n">removeAll</span><span class="p">(</span><span class="n">member</span><span \
class="p">);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">268</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="p">}</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">269</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">}</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">why are launchers with \
no window instances removed from the member list?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">isVisible() \
returns true if there's no window instance, so it get removed if there is \
one.</pre> <br />
<p>- Anton</p>
<br />
<p>On July 10th, 2010, 6:21 p.m., Anton Kreuzkamp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Anton Kreuzkamp.</div>
<p style="color: grey;"><i>Updated 2010-07-10 18:21:39</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adds support for Windows 7 like launchers in libtaskmanager. (I'm on \
holliday from 12th July until 1st August so I will not be able to reply during this \
time.)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with a small test-applett and everything works.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/libs/taskmanager/taskitem.h <span style="color: \
grey">(1148442)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp <span style="color: \
grey">(1148442)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.h <span style="color: \
grey">(1148442)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/programgroupingstrategy.cpp \
<span style="color: grey">(1148442)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp <span \
style="color: grey">(1148442)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h <span style="color: \
grey">(1148442)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.h <span \
style="color: grey">(1148442)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/taskmanager/abstractsortingstrategy.cpp <span \
style="color: grey">(1148442)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/taskmanager/CMakeLists.txt <span style="color: \
grey">(1148442)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4585/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic