[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Added feature in "showdesktop" widget to minimize
From: "Shantanu Tushar Jha" <jhahoneyk () gmail ! com>
Date: 2010-08-18 14:47:53
Message-ID: 20100818144753.31463.55609 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-08-18 07:57:04, Marco Martin wrote:
> > perfect, go for it! (if you need ideas for other things i also would like to see \
> > the Chani's suggestion :p)
>
> Sinny Kumari wrote:
> Thanks ! , Can someone commit it as i don't have svn account :)
Committed revision 1165216.
WebSVN link: http://websvn.kde.org/?view=revision&revision=1165216
Please close the review as Submitted.
- Shantanu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5060/#review7127
-----------------------------------------------------------
On 2010-08-18 05:34:12, Sinny Kumari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5060/
> -----------------------------------------------------------
>
> (Updated 2010-08-18 05:34:12)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Earlier, when I was trying to drag any file/folder on desktop from an opened window \
> , i was unable to do it because there was no option to minimize all opened window \
> when an item is dragged. So, I added feature to "minimize all opened window" in \
> "showdesktop" widget when any item is dragged from opened window. It's possible by \
> hovering the mouse in dragged condition over "showdesktop" widget icon in panel.
>
> Diffs
> -----
>
> trunk/KDE/kdeplasma-addons/applets/showdesktop/showdesktop.h 1162122
> trunk/KDE/kdeplasma-addons/applets/showdesktop/showdesktop.cpp 1162122
>
> Diff: http://reviewboard.kde.org/r/5060/diff
>
>
> Testing
> -------
>
> It works fine with trunk!
>
>
> Thanks,
>
> Sinny
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5060/">http://reviewboard.kde.org/r/5060/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 18th, 2010, 7:57 a.m., <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">perfect, go for it! (if you need ideas for other things i also would \
like to see the Chani's suggestion :p)</pre> </blockquote>
<p>On August 18th, 2010, 1:25 p.m., <b>Sinny Kumari</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks ! , Can someone \
commit it as i don't have svn account :)</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Committed revision \
1165216. WebSVN link: http://websvn.kde.org/?view=revision&revision=1165216
Please close the review as Submitted.</pre>
<br />
<p>- Shantanu</p>
<br />
<p>On August 18th, 2010, 5:34 a.m., Sinny Kumari wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Sinny Kumari.</div>
<p style="color: grey;"><i>Updated 2010-08-18 05:34:12</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Earlier, when I was trying to drag any file/folder on desktop from an \
opened window , i was unable to do it because there was no option to minimize all \
opened window when an item is dragged. So, I added feature to "minimize all \
opened window" in "showdesktop" widget when any item is dragged from \
opened window. It's possible by hovering the mouse in dragged condition over \
"showdesktop" widget icon in panel. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It works fine with trunk!</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdeplasma-addons/applets/showdesktop/showdesktop.h <span style="color: \
grey">(1162122)</span></li>
<li>trunk/KDE/kdeplasma-addons/applets/showdesktop/showdesktop.cpp <span \
style="color: grey">(1162122)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5060/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic