[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: PlasmaKPart moved to kdereview
From:       David Faure <faure () kde ! org>
Date:       2010-08-17 19:21:27
Message-ID: 201008172121.28098.faure () kde ! org
[Download RAW message or body]

On Friday 13 August 2010, Richard Moore wrote:
> bool openFile() { return true; }; inline method and dubious

This one is actually OK in ReadOnlyPart derived classes.
If you reimplement openUrl(), then openFile() can be just "return false" (the 
docs say to return false, not true, but it really doesn't matter, it's never 
called).

Years after the fact, I can see that openFile() shouldn't have been a pure 
virtual, but a simple " { return false; }" default implementation. I guess I 
can make that change now, actually, this should be BC/SC. Doing that now.

-- 
David Faure, faure@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]