'Re: Review Request: Counting up/stopwatch on the timer plasmoid'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Counting up/stopwatch on the timer plasmoid
From:       "Alex Raymond" <raymond.alex () gmail ! com>
Date:       2010-08-09 20:06:51
Message-ID: 20100809200651.8760.97357 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4955/
-----------------------------------------------------------

(Updated 2010-08-09 20:06:50.979397)

Review request for Plasma and Tomaz Canabrava.

Changes
-------

Fixed (I guess!).

Summary
-------

Adds a Count Up action on the timer plasmoid, allowing it to time things :)
Also, the ordinary Start is renamed to Count Down.

Diffs (updated)
-----

  /trunk/KDE/kdeplasma-addons/applets/timer/timer.h 1161069 =

  /trunk/KDE/kdeplasma-addons/applets/timer/timer.cpp 1161069 =

Diff: http://reviewboard.kde.org/r/4955/diff

Testing
-------

Works fine here.

Thanks,

Alex

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4955/">http://reviewboard.kde.org/r/4955/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Tomaz Canabrava.</div>
<div>By Alex Raymond.</div>

<p style="color: grey;"><i>Updated 2010-08-09 20:06:50.979397</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixed (I guess!).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adds a Count Up action on the timer plasmoid, allowing it to time things \
:) Also, the ordinary Start is renamed to Count Down.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works fine here.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdeplasma-addons/applets/timer/timer.h <span style="color: \
grey">(1161069)</span></li>

 <li>/trunk/KDE/kdeplasma-addons/applets/timer/timer.cpp <span style="color: \
grey">(1161069)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4955/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 