[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Supporting theme colors on the fifteenPuzzle
From: "Aaron Seigo" <aseigo () kde ! org>
Date: 2010-08-04 18:53:06
Message-ID: 20100804185306.1953.26018 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-08-04 18:33:46, Aaron Seigo wrote:
> > is that really a problem? if you choose a custom colour .. you choose a=
custom colour.
> =
> Alex Raymond wrote:
> But the problem is that if you manually select the theme color from t=
he theme A, which is red, and then change to theme B, which is blue. It wil=
l keep opening as red, because the color itself is saved, and not the "them=
e color" choice itself.
ah, you mean if they select the theme colour? imho: treat that item behind =
the scenes as a special "No custom color" option. :)
- Aaron
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4904/#review6796
-----------------------------------------------------------
On 2010-08-04 18:13:29, Alex Raymond wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4904/
> -----------------------------------------------------------
> =
> (Updated 2010-08-04 18:13:29)
> =
> =
> Review request for Plasma, Aaron Seigo and Tomaz Canabrava.
> =
> =
> Summary
> -------
> =
> This patch automatically adds the current background Plasma color as the =
first in the KColorCombo list. :)
> =
> =
> Diffs
> -----
> =
> /trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzle.cp=
p 1159160 =
> /trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzleCon=
fig.cpp 1159160 =
> =
> Diff: http://reviewboard.kde.org/r/4904/diff
> =
> =
> Testing
> -------
> =
> It works fine, but there is still a problem. If you manually select a the=
me color, and have your theme changed afterwards, you will need to manually=
re-select the theme color on the list in order to make it go for the right=
one. Any suggestions?
> =
> =
> Thanks,
> =
> Alex
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4904/">http://reviewboard.kde.org/r/4904/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 4th, 2010, 6:33 p.m., <b>Aaron Seigo</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">is that \
really a problem? if you choose a custom colour .. you choose a custom colour.</pre> \
</blockquote>
<p>On August 4th, 2010, 6:36 p.m., <b>Alex Raymond</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">But the problem is that \
if you manually select the theme color from the theme A, which is red, and then \
change to theme B, which is blue. It will keep opening as red, because the color \
itself is saved, and not the "theme color" choice itself.</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ah, you mean if they \
select the theme colour? imho: treat that item behind the scenes as a special \
"No custom color" option. :)</pre> <br />
<p>- Aaron</p>
<br />
<p>On August 4th, 2010, 6:13 p.m., Alex Raymond wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Aaron Seigo and Tomaz Canabrava.</div>
<div>By Alex Raymond.</div>
<p style="color: grey;"><i>Updated 2010-08-04 18:13:29</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch automatically adds the current background Plasma color as the \
first in the KColorCombo list. :)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It works fine, but there is still a problem. If you manually select a \
theme color, and have your theme changed afterwards, you will need to manually \
re-select the theme color on the list in order to make it go for the right one. Any \
suggestions?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzle.cpp <span \
style="color: grey">(1159160)</span></li>
<li>/trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzleConfig.cpp \
<span style="color: grey">(1159160)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4904/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic