From kde-panel-devel Sat Jul 31 23:52:42 2010 From: "Rafa? Mi?ecki" Date: Sat, 31 Jul 2010 23:52:42 +0000 To: kde-panel-devel Subject: Re: Review Request: battery: Support for any amount of brightness Message-Id: <20100731235242.18978.90912 () localhost> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=128062037317024 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1200823153==" --===============1200823153== Content-Type: multipart/alternative; boundary="===============0175882676871213126==" --===============0175882676871213126== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4796/#review6757 ----------------------------------------------------------- Commited in following commits: 1157703 1157711 1157714 1157716 Commits with CC-ed bug 199520 - Rafa? On 2010-07-30 08:23:16, Rafa? Mi?ecki wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4796/ > ----------------------------------------------------------- > = > (Updated 2010-07-30 08:23:16) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > Currently we always display one brightness slider, even if there is not b= r device at all (see bug #199520) or if there are more devices that should = be controlled. > = > With this patch we fetch all devices and generate one label&slider pair f= or each. > = > The most confusing thing for me in implementation was storing list of sli= ders assigned to devices names. For that purpose I introduced struct Bright= nessSet. I don't know if it is clean and acceptable solution, however keepi= ng something like > QMap > *m_brightnessControlls > didn't sound too great to me. > = > = > This addresses bug 199520. > https://bugs.kde.org/show_bug.cgi?id=3D199520 > = > = > Diffs > ----- > = > /trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.h 1= 156862 = > /trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp= 1156862 = > = > Diff: http://reviewboard.kde.org/r/4796/diff > = > = > Testing > ------- > = > I don't have two brightness devices, so I didn't test that part. > = > After removing "video" kernel module I didn't get any slider which is goo= d. > = > I also put some: > qDebug() << "setting" << bs->device > to make sure my list of names and sliders works fine. > = > = > Thanks, > = > Rafa? > = > --===============0175882676871213126== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde= .org/r/4796/ 

Commited in following commits:
1157703
1157711
1157714
1157716

Commits with CC-ed bug 199520

- Rafa?


On July 30th, 2010, 8:23 a.m., Rafa? Mi?ecki wrote:

Review request for Plasma.
By Rafa? Mi?ecki.

Updated 2010-07-30 08:23:16

Descripti= on 

Currently we always display one br=
ightness slider, even if there is not br device at all (see bug #199520) or=
 if there are more devices that should be controlled.

With this patch we fetch all devices and generate one label&slider pair=
 for each.

The most confusing thing for me in implementation was storing list of slide=
rs assigned to devices names. For that purpose I introduced struct Brightne=
ssSet. I don't know if it is clean and acceptable solution, however kee=
ping something like
QMap<QPair<Plasma::Label *, Plasma::Slider *> > *m_brightnessCo=
ntrolls
didn't sound too great to me.

Testing <= /h1> 
I don't have two brightness de=
vices, so I didn't test that part.

After removing "video" kernel module I didn't get any slider =
which is good.

I also put some:
qDebug() << "setting" << bs->device
to make sure my list of names and sliders works fine.
Bugs: 199520

Diffs=

  • /trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.h = (1156862)
  • /trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cp= p (1156862)

View Diff
--===============0175882676871213126==-- --===============1200823153== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1200823153==--