--===============1011568349== Content-Type: multipart/alternative; boundary="===============4406155462023530875==" --===============4406155462023530875== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2010-07-23 18:31:44, Aaron Seigo wrote: > > looks good to me; as long as Frederik is cool with it as well (as he is= the author/maintainer of folderview :), then this should go in > = > Iamluc wrote: > Thanks. > I do not have a SVN account, so if you could commit it.... (Of course= if Frederik is OK !) :-) ok, i'll work on integrating & testing it today. btw, if you wish to continue submitting patches (and i hope you do! i see y= ou posted another one for kio, e.g. :), then we should get you your own acc= ount so you can do the committing and what not yourself :) - Aaron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4519/#review6693 ----------------------------------------------------------- On 2010-07-22 17:14:18, Iamluc wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4519/ > ----------------------------------------------------------- > = > (Updated 2010-07-22 17:14:18) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > Hello, > = > This patch add a Plasma::Label with text "This folder is empty." in Folde= rview's Popup when the folder is empty. > = > The related bug number in kde bugzilla is 201542. > = > Luc > = > = > This addresses bug 201542. > https://bugs.kde.org/show_bug.cgi?id=3D201542 > = > = > Diffs > ----- > = > /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 1151820 = > /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1151820 = > = > Diff: http://reviewboard.kde.org/r/4519/diff > = > = > Testing > ------- > = > Delete/add files several times. The label disappears/appears correctly. > = > = > Screenshots > ----------- > = > folderview empty folder > http://reviewboard.kde.org/r/4519/s/444/ > version 2 > http://reviewboard.kde.org/r/4519/s/455/ > = > = > Thanks, > = > Iamluc > = > --===============4406155462023530875== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde= .org/r/4519/

On July 23rd, 2010, 6:31 p.m., Aaron Seigo<= /b> wrote:

looks good to me; as long as Frederik is cool with it as well (as he= is the author/maintainer of folderview :), then this should go in

On July 25th, 2010, 6:42 p.m., Iamluc wrote:

Thanks. I do not have a SVN account, so if you could commit it.... (Of course if Fr= ederik is OK !) :-)

ok, i'll work on integrating & testing it today. btw, if you wish to continue submitting patches (and i hope you do! i see y= ou posted another one for kio, e.g. :), then we should get you your own acc= ount so you can do the committing and what not yourself :)

- Aaron

On July 22nd, 2010, 5:14 p.m., Iamluc wrote:

Review request for Plasma.

By Iamluc.

Updated 2010-07-22 17:14:18

Descripti= on

Hello, This patch add a Plasma::Label with text "This folder is empty." = in Folderview's Popup when the folder is empty. The related bug number in kde bugzilla is 201542. Luc

Testing <= /h1>

Delete/add files several times. Th= e label disappears/appears correctly.

Bugs: 201542

Diffs=

/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h (1151820)

/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp (1151820)

View Diff

Screensho= ts

--===============4406155462023530875==-- --===============1011568349== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1011568349==--