'Re: Review Request: Add plasma ToolTip to fileWatcher'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Add plasma ToolTip to fileWatcher
From:       "Shantanu Tushar Jha" <jhahoneyk () gmail ! com>
Date:       2010-07-23 5:57:46
Message-ID: 20100723055746.3857.26444 () localhost
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4730/#review6677
-----------------------------------------------------------

Ship it!

Committed revision 1153316.
WebSVN link http://websvn.kde.org/trunk/KDE/kdeplasma-addons/applets/fileWatcher/fileWatcher.cpp?revision=1153316&view=markup

Please close the review as Submitted.

- Shantanu

On 2010-07-21 18:46:42, Sinny Kumari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4730/
> -----------------------------------------------------------
> 
> (Updated 2010-07-21 18:46:42)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Previously,in fileWatcher widget , during hovering it was showing the path of file \
> added to it in traditional QtToolTip format. So,i changed its hovering effect to \
> the plasma::tooltip style which looks very nice. 
> 
> Diffs
> -----
> 
> trunk/KDE/kdeplasma-addons/applets/fileWatcher/fileWatcher.h 1148418 
> trunk/KDE/kdeplasma-addons/applets/fileWatcher/fileWatcher.cpp 1148418 
> 
> Diff: http://reviewboard.kde.org/r/4730/diff
> 
> 
> Testing
> -------
> 
> It works fine with Trunk.
> 
> 
> Thanks,
> 
> Sinny
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4730/">http://reviewboard.kde.org/r/4730/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre>Committed revision 1153316.
WebSVN link http://websvn.kde.org/trunk/KDE/kdeplasma-addons/applets/fileWatcher/fileWatcher.cpp?revision=1153316&amp;view=markup

Please close the review as Submitted.</pre>
 <br />

<p>- Shantanu</p>

<br />
<p>On July 21st, 2010, 6:46 p.m., Sinny Kumari wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Sinny Kumari.</div>

<p style="color: grey;"><i>Updated 2010-07-21 18:46:42</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">Previously,in fileWatcher widget , during \
hovering it was showing the path of file added to it in traditional QtToolTip format. \
So,i changed its hovering effect to the plasma::tooltip style which looks very \
nice.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">It works fine with Trunk.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/KDE/kdeplasma-addons/applets/fileWatcher/fileWatcher.h <span style="color: \
grey">(1148418)</span></li>

 <li>trunk/KDE/kdeplasma-addons/applets/fileWatcher/fileWatcher.cpp <span \
style="color: grey">(1148418)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4730/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 