'Re: Review Request: Folderview : label when empty folder'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Folderview : label when empty folder
From:       "Iamluc" <luc () vieillescazes ! net>
Date:       2010-07-22 17:14:18
Message-ID: 20100722171418.21930.4091 () localhost
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4519/
-----------------------------------------------------------

(Updated 2010-07-22 17:14:18.528780)

Review request for Plasma.

Changes
-------

Avoid full repaint when not necessary by using a bool m_folderIsEmpty.

Add Aaron changes to hide the message when folderview is used as a containment

Summary
-------

Hello,

This patch add a Plasma::Label with text "This folder is empty." in Folderview's \
Popup when the folder is empty.

The related bug number in kde bugzilla is 201542.

Luc

This addresses bug 201542.
    https://bugs.kde.org/show_bug.cgi?id=201542

Diffs (updated)
-----

  /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 1151820 
  /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1151820 

Diff: http://reviewboard.kde.org/r/4519/diff

Testing
-------

Delete/add files several times. The label disappears/appears correctly.

Screenshots
-----------

folderview empty folder
  http://reviewboard.kde.org/r/4519/s/444/
version 2
  http://reviewboard.kde.org/r/4519/s/455/

Thanks,

Iamluc

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4519/">http://reviewboard.kde.org/r/4519/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Iamluc.</div>

<p style="color: grey;"><i>Updated 2010-07-22 17:14:18.528780</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">Avoid full repaint when not necessary by using \
a bool m_folderIsEmpty.

Add Aaron changes to hide the message when folderview is used as a containment</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">Hello,

This patch add a Plasma::Label with text &quot;This folder is empty.&quot; in \
Folderview&#39;s Popup when the folder is empty.

The related bug number in kde bugzilla is 201542.

Luc</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">Delete/add files several times. The label \
disappears/appears correctly.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=201542">201542</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h <span style="color: \
grey">(1151820)</span></li>

 <li>/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp <span \
style="color: grey">(1151820)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4519/diff/" style="margin-left: 3em;">View \
Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://reviewboard.kde.org/r/4519/s/444/"><img \
src="http://reviewboard.kde.org/media/uploaded/images/2010/07/03/folderview_400x100.png" \
style="border: 1px black solid;" alt="folderview empty folder" /></a>

 <a href="http://reviewboard.kde.org/r/4519/s/455/"><img \
src="http://reviewboard.kde.org/media/uploaded/images/2010/07/08/folderview2_400x100.png" \
style="border: 1px black solid;" alt="version 2" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 