--===============1268496639== Content-Type: multipart/alternative; boundary="===============0009613059117268087==" --===============0009613059117268087== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2010-07-19 21:33:59, Aaron Seigo wrote: > > i love the amount of red in this one :) > > = > > only comment i have is that if the close button were moved into Filteri= ngWidget itself, and a "closeClicked()" signal added to it, then the somewh= at nasty static_cast to assign filteringLayout could be removed and all of = that code could be encapsulated in FilteringWidget. with that done, i think= this should go into svn :) > = > Aur=C3=A9lien G=C3=A2teau wrote: > I can move the close button inside FilteringWidget, but that would me= an that in vertical orientation the close button would move from the bottom= -left corner to the top-right. If we do this we should move the close butto= n of the panel which contains the "Add Widgets..." button as well, for cons= istency. i think moving the button to the top right in vertical would be a good move= , regardless. as you pointed out the other week @ akademy, it would free up= more vertical space and would be more consistent in general. - Aaron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4676/#review6644 ----------------------------------------------------------- On 2010-07-17 23:05:49, Aur=C3=A9lien G=C3=A2teau wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4676/ > ----------------------------------------------------------- > = > (Updated 2010-07-17 23:05:49) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > Make AbstractIconList inherit from Plasma::ScrollWidget, has discussed on= plasma-devel. > = > The horizontal orientation behaved a bit strangely: AbstractIconList was = becoming much larger than the screen width. I had to change the layout code= to include the "Close" button inside FilteringWidget layout instead of cre= ating another layout. > = > Note: you need http://reviewboard.kde.org/r/4675/ to get proper scrollbar= slider sizes. > = > = > Diffs > ----- > = > trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.h = 1147944 = > trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.cp= p 1147944 = > trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/app= letslist.h 1147944 = > trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/app= letslist.cpp 1147944 = > trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/wid= getexplorer.cpp 1147944 = > = > Diff: http://reviewboard.kde.org/r/4676/diff > = > = > Testing > ------- > = > Tested in both horizontal and vertical modes, with lists larger and small= er than the view. > = > = > Thanks, > = > Aur=C3=A9lien > = > --===============0009613059117268087== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde= .org/r/4676/

On July 19th, 2010, 9:33 p.m., Aaron Seigo<= /b> wrote:

i love the amount of red in this one :)

only comment i have is that if the close button were moved into FilteringWi=
dget itself, and a "closeClicked()" signal added to it, then the =
somewhat nasty static_cast to assign filteringLayout could be removed and a=
ll of that code could be encapsulated in FilteringWidget. with that done, i=
 think this should go into svn :)

On July 20th, 2010, 8:14 a.m., Aur=C3=A9lien G=C3=A2teau wrote:<= /p> 

I can move the close button inside FilteringWidget, but that would m=
ean that in vertical orientation the close button would move from the botto=
m-left corner to the top-right. If we do this we should move the close butt=
on of the panel which contains the "Add Widgets..." button as wel=
l, for consistency.
i think moving the button to the top right in vertical would be a good=
 move, regardless. as you pointed out the other week @ akademy, it would fr=
ee up more vertical space and would be more consistent in general.

- Aaron


On July 17th, 2010, 11:05 p.m., Aur=C3=A9lien G=C3=A2teau wrote:

Review request for Plasma.
By Aur=C3=A9lien G=C3=A2teau.

Updated 2010-07-17 23:05:49

Descripti= on 

Make AbstractIconList inherit from=
 Plasma::ScrollWidget, has discussed on plasma-devel.

The horizontal orientation behaved a bit strangely: AbstractIconList was be=
coming much larger than the screen width. I had to change the layout code t=
o include the "Close" button inside FilteringWidget layout instea=
d of creating another layout.

Note: you need http://reviewboard.kde.org/r/4675/ to get proper scrollbar s=
lider sizes.

Testing <= /h1> 
Tested in both horizontal and vert=
ical modes, with lists larger and smaller than the view.

Diffs=

  • trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.h= (1147944)
  • trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.c= pp (1147944)
  • trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/ap= pletslist.h (1147944)
  • trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/ap= pletslist.cpp (1147944)
  • trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/wi= dgetexplorer.cpp (1147944)

View Diff
--===============0009613059117268087==-- --===============1268496639== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1268496639==--