On July 19th, 2010, 9:33 p.m., Aaron Seigo wrote:

i love the amount of red in this one :)

only comment i have is that if the close button were moved into FilteringWidget itself, and a "closeClicked()" signal added to it, then the somewhat nasty static_cast to assign filteringLayout could be removed and all of that code could be encapsulated in FilteringWidget. with that done, i think this should go into svn :)

On July 20th, 2010, 8:14 a.m., Aurélien Gâteau wrote:

I can move the close button inside FilteringWidget, but that would mean that in vertical orientation the close button would move from the bottom-left corner to the top-right. If we do this we should move the close button of the panel which contains the "Add Widgets..." button as well, for consistency.

i think moving the button to the top right in vertical would be a good move, regardless. as you pointed out the other week @ akademy, it would free up more vertical space and would be more consistent in general.

- Aaron

On July 17th, 2010, 11:05 p.m., Aurélien Gâteau wrote:

Make AbstractIconList inherit from Plasma::ScrollWidget, has discussed on plasma-devel.

The horizontal orientation behaved a bit strangely: AbstractIconList was becoming much larger than the screen width. I had to change the layout code to include the "Close" button inside FilteringWidget layout instead of creating another layout.

Note: you need http://reviewboard.kde.org/r/4675/ to get proper scrollbar slider sizes.

Tested in both horizontal and vertical modes, with lists larger and smaller than the view.