'Re: Review Request: Fix size of scrollbar sliders in'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Fix size of scrollbar sliders in
From:       Aurélien Gâteau <agateau () kde ! org>
Date:       2010-07-19 12:58:37
Message-ID: 20100719125837.12801.67701 () localhost
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On 2010-07-19 08:32:45, Marco Martin wrote:
> > good catch :)
> =

> Aur=C3=A9lien G=C3=A2teau wrote:
>     It's in. Do you think I should backport it?

Backported to 4.5.

- Aur=C3=A9lien

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4675/#review6638
-----------------------------------------------------------

On 2010-07-17 22:54:33, Aur=C3=A9lien G=C3=A2teau wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4675/
> -----------------------------------------------------------
> =

> (Updated 2010-07-17 22:54:33)
> =

> =

> Review request for Plasma and Marco Martin.
> =

> =

> Summary
> -------
> =

> Plasma::ScrollWidget scrollbar sliders do not have the correct size: they=
 do not represent the proportion of the list which is visible. Defining the=
 page step of the scrollbars fixes this.
> =

> =

> Diffs
> -----
> =

>   trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp 1147873 =

> =

> Diff: http://reviewboard.kde.org/r/4675/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Aur=C3=A9lien
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4675/">http://reviewboard.kde.org/r/4675/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On July 19th, 2010, 8:32 a.m., <b>Marco Martin</b> \
wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">  <pre>good catch :)</pre>
 </blockquote>

 <p>On July 19th, 2010, 10:02 a.m., <b>Aurélien Gâteau</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre>It&#39;s in. Do you think I should backport it?</pre>
 </blockquote>

</blockquote>

<pre>Backported to 4.5.</pre>
<br />

<p>- Aurélien</p>

<br />
<p>On July 17th, 2010, 10:54 p.m., Aurélien Gâteau wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Marco Martin.</div>
<div>By Aurélien Gâteau.</div>

<p style="color: grey;"><i>Updated 2010-07-17 22:54:33</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">Plasma::ScrollWidget scrollbar sliders do not \
have the correct size: they do not represent the proportion of the list which is \
visible. Defining the page step of the scrollbars fixes this.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp <span style="color: \
grey">(1147873)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4675/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 