'Review Request: Use Plasma::ScrollWidget in the widget explorer'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Use Plasma::ScrollWidget in the widget explorer
From:       Aurélien Gâteau <agateau () kde ! org>
Date:       2010-07-17 23:05:49
Message-ID: 20100717230549.22965.96440 () localhost
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4676/
-----------------------------------------------------------

Review request for Plasma.

Summary
-------

Make AbstractIconList inherit from Plasma::ScrollWidget, has discussed on p=
lasma-devel.

The horizontal orientation behaved a bit strangely: AbstractIconList was be=
coming much larger than the screen width. I had to change the layout code t=
o include the "Close" button inside FilteringWidget layout instead of creat=
ing another layout.

Note: you need http://reviewboard.kde.org/r/4675/ to get proper scrollbar s=
lider sizes.

Diffs
-----

  trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.h 11=
47944 =

  trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.cpp =
1147944 =

  trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/apple=
tslist.h 1147944 =

  trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/apple=
tslist.cpp 1147944 =

  trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/widge=
texplorer.cpp 1147944 =

Diff: http://reviewboard.kde.org/r/4676/diff

Testing
-------

Tested in both horizontal and vertical modes, with lists larger and smaller=
 than the view.

Thanks,

Aur=C3=A9lien

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4676/">http://reviewboard.kde.org/r/4676/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Aurélien Gâteau.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">Make AbstractIconList inherit from \
Plasma::ScrollWidget, has discussed on plasma-devel.

The horizontal orientation behaved a bit strangely: AbstractIconList was becoming \
much larger than the screen width. I had to change the layout code to include the \
&quot;Close&quot; button inside FilteringWidget layout instead of creating another \
layout.

Note: you need http://reviewboard.kde.org/r/4675/ to get proper scrollbar slider \
sizes.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">Tested in both horizontal and vertical modes, \
with lists larger and smaller than the view.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.h <span \
style="color: grey">(1147944)</span></li>

 <li>trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.cpp <span \
style="color: grey">(1147944)</span></li>

 <li>trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletslist.h \
<span style="color: grey">(1147944)</span></li>

 <li>trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletslist.cpp \
<span style="color: grey">(1147944)</span></li>

 <li>trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/widgetexplorer.cpp \
<span style="color: grey">(1147944)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4676/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 