[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Add external loader support to Plasma::Applet,
From: "Ryan Rix" <ry () n ! rix ! si>
Date: 2010-07-15 21:21:31
Message-ID: 20100715212131.20026.15447 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-07-15 15:27:50, Aaron Seigo wrote:
> > trunk/KDE/kdelibs/plasma/externalpluginloader.cpp, line 34
> > <http://reviewboard.kde.org/r/4554/diff/4/?file=31229#file31229line34>
> >
> > i wonder if we should guard this so it can only be set once, e.g.:
> >
> > if (!s_externalPluginLoader) {
> > s_externalPluginLoader = loader;
> > }
Submitted as of r1150391
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4554/#review6587
-----------------------------------------------------------
On 2010-07-14 22:43:15, Ryan Rix wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4554/
> -----------------------------------------------------------
>
> (Updated 2010-07-14 22:43:15)
>
>
> Review request for Plasma, Aaron Seigo, Robert Marmorstein, and Shaun Reich.
>
>
> Summary
> -------
>
> Adds ability for applications which embed plasma to specify a class which plasma \
> will query for Applet, DataEngine, and Service creation, giving them the chance to \
> create these objects internally.
> The foremost use of this is to give Plasma the chance to ask applications when \
> restoring layouts from disk, for applets which were based on QWidgets, such as the \
> case in various Plasma dashboards which may embed QWidgets as plasma::applets ....
>
> Diffs
> -----
>
> trunk/KDE/kdelibs/plasma/CMakeLists.txt 1146180
> trunk/KDE/kdelibs/plasma/applet.cpp 1146180
> trunk/KDE/kdelibs/plasma/dataenginemanager.cpp 1146180
> trunk/KDE/kdelibs/plasma/externalpluginloader.h PRE-CREATION
> trunk/KDE/kdelibs/plasma/externalpluginloader.cpp PRE-CREATION
> trunk/KDE/kdelibs/plasma/service.cpp 1146180
>
> Diff: http://reviewboard.kde.org/r/4554/diff
>
>
> Testing
> -------
>
> Well, this thing is about 90% there right now, everything works, etc, afaict, but I \
> can't get the instance of the PluginManager outside of the Plasma namespace, if \
> someone could help that would be great. :) I can commit some support into \
> trunk/playground/base/shells/kpart
>
> Thanks,
>
> Ryan
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4554/">http://reviewboard.kde.org/r/4554/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 15th, 2010, 3:27 p.m., <b>Aaron Seigo</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/4554/diff/4/?file=31229#file31229line34" style="color: black; font-weight: \
bold; text-decoration: \
underline;">trunk/KDE/kdelibs/plasma/externalpluginloader.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;"></pre></td> <td colspan="2"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;">void \
ExternalPluginLoader::setPluginLoader(ExternalPluginLoader* loader)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">34</font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"> \
<span class="n">s_externalPluginLoader</span> <span class="o">=</span> <span \
class="n">loader</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre>i wonder if we should guard this so it can only be set once, e.g.:
if (!s_externalPluginLoader) {
s_externalPluginLoader = loader;
}</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em">Submitted as of r1150391</pre>
<br />
<p>- Ryan</p>
<br />
<p>On July 14th, 2010, 10:43 p.m., Ryan Rix wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Aaron Seigo, Robert Marmorstein, and Shaun \
Reich.</div> <div>By Ryan Rix.</div>
<p style="color: grey;"><i>Updated 2010-07-14 22:43:15</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">Adds ability for applications which embed \
plasma to specify a class which plasma will query for Applet, DataEngine, and Service \
creation, giving them the chance to create these objects internally.
The foremost use of this is to give Plasma the chance to ask applications when \
restoring layouts from disk, for applets which were based on QWidgets, such as the \
case in various Plasma dashboards which may embed QWidgets as plasma::applets \
....</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">Well, this thing is about 90% there right now, \
everything works, etc, afaict, but I can't get the instance of the PluginManager \
outside of the Plasma namespace, if someone could help that would be great. :) I can \
commit some support into trunk/playground/base/shells/kpart </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/plasma/CMakeLists.txt <span style="color: \
grey">(1146180)</span></li>
<li>trunk/KDE/kdelibs/plasma/applet.cpp <span style="color: \
grey">(1146180)</span></li>
<li>trunk/KDE/kdelibs/plasma/dataenginemanager.cpp <span style="color: \
grey">(1146180)</span></li>
<li>trunk/KDE/kdelibs/plasma/externalpluginloader.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/externalpluginloader.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/service.cpp <span style="color: \
grey">(1146180)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4554/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic