[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Launcher support for libtaskmanager
From: "Aaron Seigo" <aseigo () kde ! org>
Date: 2010-07-13 20:41:52
Message-ID: 20100713204152.10506.43829 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-07-10 19:13:13, Markus Slopianka wrote:
> > GPL for library files? Sounds strange to me. I'd expect at least LGPL...
> =
> Marco Martin wrote:
> this library is a big mess it already contains pieces in gpl, lgpl an=
d bsd
> this really should be fixed
> =
> Markus Slopianka wrote:
> Combining LGPL and more permissive licenses (BSD, MIT) isn't such a b=
ig deal, but I'd avoid GPL for libraries. While it's not a violation of KDE=
's Licensing Policies (that one only demands LGPL or more permissive for kd=
elibs, kdepimlibs and kdebase-runtime), it's at least inconsistent with KDE=
's general "LGPL for libraries and GPL for applications" approach.
> I suggest to Anton to use LGPL for both to at least make the situatio=
n not more messy than it already is.
er... this entire library is BSD licensed. Marco: what parts are lgpl or gp=
l?
and yes, GPL is not acceptable. out of respect for the original authors, we=
should keep it BSD licensed, including new additions.
- Aaron
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4585/#review6471
-----------------------------------------------------------
On 2010-07-10 18:21:39, Anton Kreuzkamp wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4585/
> -----------------------------------------------------------
> =
> (Updated 2010-07-10 18:21:39)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> Adds support for Windows 7 like launchers in libtaskmanager.
> (I'm on holliday from 12th July until 1st August so I will not be able to=
reply during this time.)
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdebase/workspace/libs/taskmanager/taskitem.h 1148442 =
> /trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp 1148442 =
> /trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.h 1148442 =
> /trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/programgroupin=
gstrategy.cpp 1148442 =
> /trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.cpp PRE-CREA=
TION =
> /trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.h PRE-CREATI=
ON =
> /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp 1148442 =
> /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h 1148442 =
> /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.h 1=
148442 =
> /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractsortingstrategy.c=
pp 1148442 =
> /trunk/KDE/kdebase/workspace/libs/taskmanager/CMakeLists.txt 1148442 =
> =
> Diff: http://reviewboard.kde.org/r/4585/diff
> =
> =
> Testing
> -------
> =
> Tested with a small test-applett and everything works.
> =
> =
> Thanks,
> =
> Anton
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4585/">http://reviewboard.kde.org/r/4585/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 10th, 2010, 7:13 p.m., <b>Markus \
Slopianka</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre>GPL for library files? Sounds strange to me. \
I'd expect at least LGPL...</pre> </blockquote>
<p>On July 13th, 2010, 1:54 p.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre>this library is a big mess it already contains pieces in gpl, lgpl and \
bsd this really should be fixed</pre>
</blockquote>
<p>On July 13th, 2010, 2:51 p.m., <b>Markus Slopianka</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre>Combining LGPL and more permissive licenses (BSD, MIT) isn't such a \
big deal, but I'd avoid GPL for libraries. While it's not a violation of \
KDE's Licensing Policies (that one only demands LGPL or more permissive for \
kdelibs, kdepimlibs and kdebase-runtime), it's at least inconsistent with \
KDE's general "LGPL for libraries and GPL for applications" approach. I \
suggest to Anton to use LGPL for both to at least make the situation not more messy \
than it already is.</pre> </blockquote>
</blockquote>
<pre>er... this entire library is BSD licensed. Marco: what parts are lgpl or gpl?
and yes, GPL is not acceptable. out of respect for the original authors, we should \
keep it BSD licensed, including new additions.</pre> <br />
<p>- Aaron</p>
<br />
<p>On July 10th, 2010, 6:21 p.m., Anton Kreuzkamp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Anton Kreuzkamp.</div>
<p style="color: grey;"><i>Updated 2010-07-10 18:21:39</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">Adds support for Windows 7 like launchers in \
libtaskmanager. (I'm on holliday from 12th July until 1st August so I will not be \
able to reply during this time.)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">Tested with a small test-applett and \
everything works.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/libs/taskmanager/taskitem.h <span style="color: \
grey">(1148442)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp <span style="color: \
grey">(1148442)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.h <span style="color: \
grey">(1148442)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/programgroupingstrategy.cpp \
<span style="color: grey">(1148442)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp <span \
style="color: grey">(1148442)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h <span style="color: \
grey">(1148442)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.h <span \
style="color: grey">(1148442)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/taskmanager/abstractsortingstrategy.cpp <span \
style="color: grey">(1148442)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/taskmanager/CMakeLists.txt <span style="color: \
grey">(1148442)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4585/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic