[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: [Lock/Logout] Add "switch user" button
From: "Marco Martin" <notmart () gmail ! com>
Date: 2010-07-13 13:49:17
Message-ID: 20100713134917.32477.53700 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4618/#review6528
-----------------------------------------------------------
Ship it!
to me is ok.
only thing would be it's becoming a stack a bit too high to fit in panels, but since \
it's off by default, that's fine
- Marco
On 2010-07-13 13:29:30, Ingomar Wesp wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4618/
> -----------------------------------------------------------
>
> (Updated 2010-07-13 13:29:30)
>
>
> Review request for Plasma, Frederik Gladhorn and Alexis Menard.
>
>
> Summary
> -------
>
> Trivial patch that adds a "switch user" button. I tried to follow the coding style \
> that was already present.
> For users that use the lock/logout buttons but don't use kickoff, there is no \
> easily discoverable way to switch users. They have to lock their session, get the \
> unlock dialog to appear and then click the button "switch user..." button there.
> Most of the strings as well as the code that interfaces with krunner has been taken \
> from the kickoff applet.
>
> This addresses bug 228993.
> https://bugs.kde.org/show_bug.cgi?id=228993
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/CMakeLists.txt \
> 1149404
> /trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.h 1149404
> /trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.cpp 1149404 \
>
> /trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockoutConfig.ui \
> 1149404
> Diff: http://reviewboard.kde.org/r/4618/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ingomar
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4618/">http://reviewboard.kde.org/r/4618/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre>to me is ok.
only thing would be it's becoming a stack a bit too high to fit in panels, but \
since it's off by default, that's fine</pre> <br />
<p>- Marco</p>
<br />
<p>On July 13th, 2010, 1:29 p.m., Ingomar Wesp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Frederik Gladhorn and Alexis Menard.</div>
<div>By Ingomar Wesp.</div>
<p style="color: grey;"><i>Updated 2010-07-13 13:29:30</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">Trivial patch that adds a "switch \
user" button. I tried to follow the coding style that was already present.
For users that use the lock/logout buttons but don't use kickoff, there is no \
easily discoverable way to switch users. They have to lock their session, get the \
unlock dialog to appear and then click the button "switch user..." button \
there.
Most of the strings as well as the code that interfaces with krunner has been taken \
from the kickoff applet.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=228993">228993</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/CMakeLists.txt \
<span style="color: grey">(1149404)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.h <span \
style="color: grey">(1149404)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.cpp \
<span style="color: grey">(1149404)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockoutConfig.ui \
<span style="color: grey">(1149404)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4618/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic