[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: new KWin effect: Dashboard
From: "Andreas Demmer" <ademmer () opensuse ! org>
Date: 2010-07-13 9:48:45
Message-ID: 20100713094845.26526.16630 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-07-05 06:16:45, Martin Gräßlin wrote:
> > trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.cpp, lines \
> > 58-62 <http://reviewboard.kde.org/r/4332/diff/2/?file=29941#file29941line58>
> >
> > I'm not really sure if it is a good idea to make the blur option only available \
> > if blur is loaded. I can imagine situation like setting up the effects without \
> > having compositing enabled. Maybe it's better to just have the textbox and add a \
> > comment that blur effect is required for this option to work.
> > This would also remove the Plasma dependency in the KCMs.
Ok, I'll remove the Plasma dependency: The checkbox label already sais "depends on \
`Blur ´ effect"
> On 2010-07-05 06:16:45, Martin Gräßlin wrote:
> > trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.h, line 20
> > <http://reviewboard.kde.org/r/4332/diff/2/?file=29943#file29943line20>
> >
> > You should also use the namespace in the define, so KWIN_DASHBOARD_CONFIG_H
I will also add the namespace to DASHBOARD_H in dashboard.cpp: KWIN_DASHBOARD_H
> On 2010-07-05 06:16:45, Martin Gräßlin wrote:
> > trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.h, line 196
> > <http://reviewboard.kde.org/r/4332/diff/2/?file=29945#file29945line196>
> >
> > I would not call it "Force"Blur. Just Blur. The other role is called Force, \
> > because it really forces blur in a code path where blur would be disabled.
Ok.
- Andreas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4332/#review6365
-----------------------------------------------------------
On 2010-06-29 19:29:38, Andreas Demmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4332/
> -----------------------------------------------------------
>
> (Updated 2010-06-29 19:29:38)
>
>
> Review request for kwin and Plasma.
>
>
> Summary
> -------
>
> This patch adds a new KWin effect that allows to modify the appearance of the \
> Plasma dashboard. It has a KCM configuration dialog where you can adjust \
> brightness, saturation and blur of the dashboard background. Blur depends on the \
> loaded blur plugin.
> I also patched the Plasma dashboard to recognize the loaded effect: If the effect \
> is loaded, the dashboard draws its background fully translucent. In order for the \
> Dashboard to recognize wether the effect is loaded, I added support for the effect \
> in Plasma::WindowEffects from kdelibs.
> The dashboard detection in the effect itself is hackish right now. As soon as \
> Plasma adds a proper class to the dashboard window, I will replace the hack with a \
> class-check.
>
> This addresses bugs dashboard, detection and hackish.
> https://bugs.kde.org/show_bug.cgi?id=dashboard
> https://bugs.kde.org/show_bug.cgi?id=detection
> https://bugs.kde.org/show_bug.cgi?id=hackish
>
>
> Diffs
> -----
>
> trunk/KDE/kdebase/workspace/kwin/effects/CMakeLists.txt 1144343
> trunk/KDE/kdebase/workspace/kwin/effects/blur/blur.cpp 1144343
> trunk/KDE/kdebase/workspace/kwin/effects/configs_builtins.cpp 1144343
> trunk/KDE/kdebase/workspace/kwin/effects/dashboard/CMakeLists.txt PRE-CREATION
> trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.cpp PRE-CREATION
> trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.desktop PRE-CREATION
> trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.h PRE-CREATION
> trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.cpp \
> PRE-CREATION trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.desktop \
> PRE-CREATION trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.h \
> PRE-CREATION trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.ui \
> PRE-CREATION trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.h 1144343
> trunk/KDE/kdebase/workspace/plasma/desktop/shell/dashboardview.cpp 1144343
> trunk/KDE/kdelibs/plasma/windoweffects.h 1144345
> trunk/KDE/kdelibs/plasma/windoweffects.cpp 1144345
>
> Diff: http://reviewboard.kde.org/r/4332/diff
>
>
> Testing
> -------
>
> Code compiles, plugin loads, plugin configuration dialog is registered in KCM \
> Workspace module under "all effects". If the plugin is enabled, its settings apply \
> to the dashboard.
>
> Screenshots
> -----------
>
> configuration dialog
> http://reviewboard.kde.org/r/4332/s/434/
> dashboard with modified background
> http://reviewboard.kde.org/r/4332/s/435/
>
>
> Thanks,
>
> Andreas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4332/">http://reviewboard.kde.org/r/4332/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 5th, 2010, 6:16 a.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/4332/diff/2/?file=29941#file29941line58" style="color: black; font-weight: \
bold; text-decoration: \
underline;">trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;"></pre></td> <td colspan="2"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;">void DashboardEffectConfig::load()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">58</font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"> \
<span class="c1">// make blur only an option when the effect plugin is \
enabled</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">59</font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"> \
<span class="k">if</span><span class="p">(</span><span class="o">!</span><span \
class="n">Plasma</span><span class="o">::</span><span \
class="n">WindowEffects</span><span class="o">::</span><span \
class="n">isEffectAvailable</span><span class="p">(</span> <span \
class="n">Plasma</span><span class="o">::</span><span \
class="n">WindowEffects</span><span class="o">::</span><span \
class="n">BlurBehind</span> <span class="p">)</span> <span \
class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">60</font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"> \
<span class="p">{</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">61</font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"> \
<span class="n">ui</span><span class="p">.</span><span class="n">blur</span><span \
class="o">-></span><span class="n">setEnabled</span><span class="p">(</span> <span \
class="kc">false</span> <span class="p">);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">62</font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"> \
<span class="p">}</span></pre></td> </tr>
</tbody>
</table>
<pre>I'm not really sure if it is a good idea to make the blur option only \
available if blur is loaded. I can imagine situation like setting up the effects \
without having compositing enabled. Maybe it's better to just have the textbox \
and add a comment that blur effect is required for this option to work.
This would also remove the Plasma dependency in the KCMs.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em">Ok, I'll remove the Plasma dependency: The checkbox \
label already sais "depends on `Blur ´ effect"</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 5th, 2010, 6:16 a.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/4332/diff/2/?file=29943#file29943line20" style="color: black; font-weight: \
bold; text-decoration: \
underline;">trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.h</a> \
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">20</font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: \
break-word;"><span class="cp">#ifndef DASHBOARD_CONFIG_H</span></pre></td> </tr>
</tbody>
</table>
<pre>You should also use the namespace in the define, so \
KWIN_DASHBOARD_CONFIG_H</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em">I will also add the namespace to DASHBOARD_H in \
dashboard.cpp: KWIN_DASHBOARD_H</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 5th, 2010, 6:16 a.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/4332/diff/2/?file=29945#file29945line196" style="color: black; font-weight: \
bold; text-decoration: \
underline;">trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.h</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;">enum DataRole</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">196</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"> <span class="n">WindowForceBlurRole</span> <span \
class="c1">///< For <span class="hl">fullscreen effect</span>s to enforce blurring \
of <span class="hl">w</span>ind<span class="hl">ows</span></span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">196</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: \
pre-wrap; word-wrap: break-word;"> <span class="n">WindowForceBlur<span \
class="hl">Behind</span>Role</span> <span class="c1">///< For <span \
class="hl">single window</span>s to enforce blurring of <span \
class="hl">beh</span>ind</span></pre></td> </tr>
</tbody>
</table>
<pre>I would not call it "Force"Blur. Just Blur. The other role is called \
Force, because it really forces blur in a code path where blur would be \
disabled.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em">Ok.</pre>
<br />
<p>- Andreas</p>
<br />
<p>On June 29th, 2010, 7:29 p.m., Andreas Demmer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Andreas Demmer.</div>
<p style="color: grey;"><i>Updated 2010-06-29 19:29:38</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">This patch adds a new KWin effect that allows \
to modify the appearance of the Plasma dashboard. It has a KCM configuration dialog \
where you can adjust brightness, saturation and blur of the dashboard background. \
Blur depends on the loaded blur plugin.
I also patched the Plasma dashboard to recognize the loaded effect: If the effect is \
loaded, the dashboard draws its background fully translucent. In order for the \
Dashboard to recognize wether the effect is loaded, I added support for the effect in \
Plasma::WindowEffects from kdelibs.
The dashboard detection in the effect itself is hackish right now. As soon as Plasma \
adds a proper class to the dashboard window, I will replace the hack with a \
class-check.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">Code compiles, plugin loads, plugin \
configuration dialog is registered in KCM Workspace module under "all \
effects". If the plugin is enabled, its settings apply to the dashboard.</pre> \
</td> </tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=dashboard">dashboard</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=detection">detection</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=hackish">hackish</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdebase/workspace/kwin/effects/CMakeLists.txt <span style="color: \
grey">(1144343)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/blur/blur.cpp <span style="color: \
grey">(1144343)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/configs_builtins.cpp <span \
style="color: grey">(1144343)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/dashboard/CMakeLists.txt <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.desktop <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.desktop \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.ui <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.h <span style="color: \
grey">(1144343)</span></li>
<li>trunk/KDE/kdebase/workspace/plasma/desktop/shell/dashboardview.cpp <span \
style="color: grey">(1144343)</span></li>
<li>trunk/KDE/kdelibs/plasma/windoweffects.h <span style="color: \
grey">(1144345)</span></li>
<li>trunk/KDE/kdelibs/plasma/windoweffects.cpp <span style="color: \
grey">(1144345)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4332/diff/" style="margin-left: 3em;">View \
Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://reviewboard.kde.org/r/4332/s/434/"><img \
src="http://reviewboard.kde.org/media/uploaded/images/2010/06/15/dashboard_config_400x100.jpeg" \
style="border: 1px black solid;" alt="configuration dialog" /></a>
<a href="http://reviewboard.kde.org/r/4332/s/435/"><img \
src="http://reviewboard.kde.org/media/uploaded/images/2010/06/15/dashboard_400x100.jpeg" \
style="border: 1px black solid;" alt="dashboard with modified background" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic