[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Launcher support for libtaskmanager
From:       "Anton Kreuzkamp" <akreuzkamp () web ! de>
Date:       2010-07-10 17:21:34
Message-ID: 20100710172134.28275.19017 () localhost
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4585/
-----------------------------------------------------------

(Updated 2010-07-10 17:21:34.119645)


Review request for Plasma.


Summary
-------

Adds support for Windows 7 like launchers in libtaskmanager.
(I'm on holliday from 12th July until 1st August so I will not be able to r=
eply during this time.)


Diffs (updated)
-----

  /trunk/KDE/kdebase/workspace/libs/taskmanager/taskitem.h 1148442 =

  /trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp 1148442 =

  /trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.h 1148442 =

  /trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/programgroupings=
trategy.cpp 1148442 =

  /trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.cpp PRE-CREATI=
ON =

  /trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.h PRE-CREATION =

  /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp 1148442 =

  /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h 1148442 =

  /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.h 114=
8442 =

  /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractsortingstrategy.cpp=
 1148442 =

  /trunk/KDE/kdebase/workspace/libs/taskmanager/CMakeLists.txt 1148442 =


Diff: http://reviewboard.kde.org/r/4585/diff


Testing
-------

Tested with a small test-applett and everything works.


Thanks,

Anton


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4585/">http://reviewboard.kde.org/r/4585/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Anton Kreuzkamp.</div>


<p style="color: grey;"><i>Updated 2010-07-10 17:21:34.119645</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">Adds support for Windows 7 like launchers in \
libtaskmanager. (I&#39;m on holliday from 12th July until 1st August so I will not be \
able to reply during this time.)</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">Tested with a small test-applett and \
everything works.</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdebase/workspace/libs/taskmanager/taskitem.h <span style="color: \
grey">(1148442)</span></li>

 <li>/trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp <span style="color: \
grey">(1148442)</span></li>

 <li>/trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.h <span style="color: \
grey">(1148442)</span></li>

 <li>/trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/programgroupingstrategy.cpp \
<span style="color: grey">(1148442)</span></li>

 <li>/trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>/trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>/trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp <span \
style="color: grey">(1148442)</span></li>

 <li>/trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h <span style="color: \
grey">(1148442)</span></li>

 <li>/trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.h <span \
style="color: grey">(1148442)</span></li>

 <li>/trunk/KDE/kdebase/workspace/libs/taskmanager/abstractsortingstrategy.cpp <span \
style="color: grey">(1148442)</span></li>

 <li>/trunk/KDE/kdebase/workspace/libs/taskmanager/CMakeLists.txt <span style="color: \
grey">(1148442)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4585/diff/" style="margin-left: 3em;">View \
Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic