'Re: Review Request: Fix a bogus message indicator item in hidden'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Fix a bogus message indicator item in hidden
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2010-07-10 8:53:23
Message-ID: 20100710085323.15900.24928 () localhost
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4541/#review6462
-----------------------------------------------------------

'notifier' is the correct name for the widget in question. message-indicator is an ubuntu add-on.

- Aaron

On 2010-07-08 21:06:50, Octavian Voicu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4541/
> -----------------------------------------------------------
> 
> (Updated 2010-07-08 21:06:50)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Possible fix for a bug in KDE system tray component.
> 
> I'm not up-to-date with recent plasma changes, but I'm guessing that at some
> point the `Message Indicator' widget changed its plugin name from `notifier' to
> `message-indicator'.
> 
> The system tray applet, when invoked for the first time, tries to make sure
> essential widgets are included, and adds `notifier' (the old "fake" message
> indicator), when it should probably add `message-indicator'.
> 
> Excerpt from ~/.kde/share/config/plasma-desktop-appletsrc:
> 
> [Containments][4][Applets][10][Configuration][Applets][2]
> plugin=message-indicator
> ...
> 
> [Containments][4][Applets][10][Configuration][Applets][3]
> plugin=notifier
> ...
> 
> I attached a fix for this, which adds `message-indicator' instead of
> `notifier'. An alternative fix would be to delete the offending lines entirely,
> but I'm guessing we want the message indicator widget to show up by default.
> 
> For screenshot and more info see https://bugs.kde.org/show_bug.cgi?id=242637
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/applet.cpp 1144396 
> 
> Diff: http://reviewboard.kde.org/r/4541/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Octavian
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4541/">http://reviewboard.kde.org/r/4541/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre>&#39;notifier&#39; is the correct name for the widget in question. \
message-indicator is an ubuntu add-on.</pre>  <br />

<p>- Aaron</p>

<br />
<p>On July 8th, 2010, 9:06 p.m., Octavian Voicu wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Octavian Voicu.</div>

<p style="color: grey;"><i>Updated 2010-07-08 21:06:50</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">Possible fix for a bug in KDE system tray \
component.

I&#39;m not up-to-date with recent plasma changes, but I&#39;m guessing that at some
point the `Message Indicator&#39; widget changed its plugin name from `notifier&#39; \
to `message-indicator&#39;.

The system tray applet, when invoked for the first time, tries to make sure
essential widgets are included, and adds `notifier&#39; (the old &quot;fake&quot; \
message indicator), when it should probably add `message-indicator&#39;.

Excerpt from ~/.kde/share/config/plasma-desktop-appletsrc:

[Containments][4][Applets][10][Configuration][Applets][2]
plugin=message-indicator
...

[Containments][4][Applets][10][Configuration][Applets][3]
plugin=notifier
...

I attached a fix for this, which adds `message-indicator&#39; instead of
`notifier&#39;. An alternative fix would be to delete the offending lines entirely,
but I&#39;m guessing we want the message indicator widget to show up by default.

For screenshot and more info see https://bugs.kde.org/show_bug.cgi?id=242637
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/applet.cpp \
<span style="color: grey">(1144396)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4541/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 