[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Fix a bogus message indicator item in hidden
From: "Octavian Voicu" <octavian.voicu () gmail ! com>
Date: 2010-07-09 15:36:26
Message-ID: 20100709153626.23023.95543 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-07-09 11:50:08, Aurélien Gâteau wrote:
> > Judging from this screenshot from the bugreport \
> > http://bugsfiles.kde.org/attachment.cgi?id=48278, it seems the system is running \
> > Kubuntu Plasma Message Indicator, which happens to be named message-indicator. \
> > Could this be the cause of the problem?
>
> Aurélien Gâteau wrote:
> links works better without the comma: \
> http://bugsfiles.kde.org/attachment.cgi?id=48278
I have the plasma-widget-message-indicator package installed (KDE SC 4.5 RC from \
Kubuntu 9.10 ppa).
I uninstalled the above package, logged out, deleted the \
/.kde/share/config/plasma-desktop-appletsrc config file, logged back in and there was \
no message indicator visible. Then I reinstalled the package, logged out, logged back \
in, and there I had it: both message indicators (the real one and the fake one).
The application that actually uses the message indicator is Pidgin (version 2.7.1). \
As I said in the original report, the bogus item, when clicked, shows the same thing \
as when I click the real one (which is usually not hidden; the bogus one is always \
hidden).
Which should be the correct name of the widget in the latest version, \
message-indicator or notifier? If it's the latter, how come it also recognizes \
message-indicator and starts it up?
- Octavian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4541/#review6440
-----------------------------------------------------------
On 2010-07-08 21:06:50, Octavian Voicu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4541/
> -----------------------------------------------------------
>
> (Updated 2010-07-08 21:06:50)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Possible fix for a bug in KDE system tray component.
>
> I'm not up-to-date with recent plasma changes, but I'm guessing that at some
> point the `Message Indicator' widget changed its plugin name from `notifier' to
> `message-indicator'.
>
> The system tray applet, when invoked for the first time, tries to make sure
> essential widgets are included, and adds `notifier' (the old "fake" message
> indicator), when it should probably add `message-indicator'.
>
> Excerpt from ~/.kde/share/config/plasma-desktop-appletsrc:
>
> [Containments][4][Applets][10][Configuration][Applets][2]
> plugin=message-indicator
> ...
>
> [Containments][4][Applets][10][Configuration][Applets][3]
> plugin=notifier
> ...
>
> I attached a fix for this, which adds `message-indicator' instead of
> `notifier'. An alternative fix would be to delete the offending lines entirely,
> but I'm guessing we want the message indicator widget to show up by default.
>
> For screenshot and more info see https://bugs.kde.org/show_bug.cgi?id=242637
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/applet.cpp \
> 1144396
> Diff: http://reviewboard.kde.org/r/4541/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Octavian
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4541/">http://reviewboard.kde.org/r/4541/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 9th, 2010, 11:50 a.m., <b>Aurélien \
Gâteau</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre>Judging from this screenshot from the bugreport \
http://bugsfiles.kde.org/attachment.cgi?id=48278, it seems the system is running \
Kubuntu Plasma Message Indicator, which happens to be named message-indicator. Could \
this be the cause of the problem?</pre> </blockquote>
<p>On July 9th, 2010, 11:50 a.m., <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre>links works better without the comma: \
http://bugsfiles.kde.org/attachment.cgi?id=48278 </pre> </blockquote>
</blockquote>
<pre>I have the plasma-widget-message-indicator package installed (KDE SC 4.5 RC from \
Kubuntu 9.10 ppa).
I uninstalled the above package, logged out, deleted the \
/.kde/share/config/plasma-desktop-appletsrc config file, logged back in and there was \
no message indicator visible. Then I reinstalled the package, logged out, logged back \
in, and there I had it: both message indicators (the real one and the fake one).
The application that actually uses the message indicator is Pidgin (version 2.7.1). \
As I said in the original report, the bogus item, when clicked, shows the same thing \
as when I click the real one (which is usually not hidden; the bogus one is always \
hidden).
Which should be the correct name of the widget in the latest version, \
message-indicator or notifier? If it's the latter, how come it also recognizes \
message-indicator and starts it up? </pre>
<br />
<p>- Octavian</p>
<br />
<p>On July 8th, 2010, 9:06 p.m., Octavian Voicu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Octavian Voicu.</div>
<p style="color: grey;"><i>Updated 2010-07-08 21:06:50</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">Possible fix for a bug in KDE system tray \
component.
I'm not up-to-date with recent plasma changes, but I'm guessing that at some
point the `Message Indicator' widget changed its plugin name from `notifier' \
to `message-indicator'.
The system tray applet, when invoked for the first time, tries to make sure
essential widgets are included, and adds `notifier' (the old "fake" \
message indicator), when it should probably add `message-indicator'.
Excerpt from ~/.kde/share/config/plasma-desktop-appletsrc:
[Containments][4][Applets][10][Configuration][Applets][2]
plugin=message-indicator
...
[Containments][4][Applets][10][Configuration][Applets][3]
plugin=notifier
...
I attached a fix for this, which adds `message-indicator' instead of
`notifier'. An alternative fix would be to delete the offending lines entirely,
but I'm guessing we want the message indicator widget to show up by default.
For screenshot and more info see https://bugs.kde.org/show_bug.cgi?id=242637
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/applet.cpp \
<span style="color: grey">(1144396)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4541/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic