From kde-panel-devel  Tue Jun 29 15:58:41 2010
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: Tue, 29 Jun 2010 15:58:41 +0000
To: kde-panel-devel
Subject: Re: KDE/kdebase/workspace/plasma/desktop/shell
Message-Id: <201006290858.41973.aseigo () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=127782719610630
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============0322073866=="

--===============0322073866==
Content-Type: multipart/signed;
  boundary="nextPart2652194.FI1fZFElmh";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart2652194.FI1fZFElmh
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

On June 28, 2010, Marco Martin wrote:
> SVN commit 1143845 by mart:
>=20
> avoid a crash in the following scenario: change the activity type of a
> containment, then try to stop the activity. it still misbehaves, because
> the new containment it gets created is not added to the activity

ah, because in insertContainment there is this:

    QPair<int,int> key(screen, desktop);
    if (m_containments.contains(key)) {
        //this almost certainly means someone has been meddling where they=
=20
shouldn't
        //but we should protect them from harm anyways
        kDebug() << "@!@!@!@!@!@@@@rejecting containment!!!";
        cont->context()->setCurrentActivityId(QString());
        return;
    }

protecting against deletion behind Activity's back is fine (so i think your=
=20
commit should be backported), but this particular problem stems from=20
BackgroundDialog in libplasmagenericshell and Activity in plasma-desktop. t=
hey=20
aren't really welld designed to work together. there are various possible w=
ays=20
to improve the situation, such as giving BackgroundDialog a virtual method=
=20
that does the actual swapContainment call and which plasma-desktop could re-
implemented internally to do the Activity coordination.

now that activities are in basically there, we can start sorting out these=
=20
interface issues in 4.6. the BackgroundDialog class needs work anyways.

for 4.5, though, i'd recommend just backporting your commit.

=2D-=20
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks

--nextPart2652194.FI1fZFElmh
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.12 (GNU/Linux)

iEYEABECAAYFAkwqGDEACgkQ1rcusafx20PozwCfQqwecJWJI7/gf808+NOSF4sU
c00AoKLwIEmpadJIPcyqh7FlL9z25vHI
=PAUn
-----END PGP SIGNATURE-----

--nextPart2652194.FI1fZFElmh--

--===============0322073866==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

--===============0322073866==--