[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Don't span activities and add widget dialog over
From: "Marco Martin" <notmart () gmail ! com>
Date: 2010-06-28 16:11:50
Message-ID: 20100628161150.16178.89939 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4478/#review6313
-----------------------------------------------------------
Ship it!
seems correct to me.
positioning could still need some love tough
- Marco
On 2010-06-28 15:20:38, Beat Wolf wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4478/
> -----------------------------------------------------------
>
> (Updated 2010-06-28 15:20:38)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Use kephal for the screen geometry. Intersect with working area as suggested by \
> notmart because of another bug that would be triggered then.
>
> This addresses bug 242963.
> https://bugs.kde.org/show_bug.cgi?id=242963
>
>
> Diffs
> -----
>
> trunk/KDE/kdebase/workspace/plasma/desktop/shell/controllerwindow.cpp 1143057
>
> Diff: http://reviewboard.kde.org/r/4478/diff
>
>
> Testing
> -------
>
> Tested with panels at different locations.
>
>
> Thanks,
>
> Beat
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4478/">http://reviewboard.kde.org/r/4478/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre>seems correct to me.
positioning could still need some love tough</pre>
<br />
<p>- Marco</p>
<br />
<p>On June 28th, 2010, 3:20 p.m., Beat Wolf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Beat Wolf.</div>
<p style="color: grey;"><i>Updated 2010-06-28 15:20:38</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">Use kephal for the screen geometry. Intersect \
with working area as suggested by notmart because of another bug that would be \
triggered then.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">Tested with panels at different \
locations.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=242963">242963</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdebase/workspace/plasma/desktop/shell/controllerwindow.cpp <span \
style="color: grey">(1143057)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4478/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic