From kde-panel-devel Mon Jun 21 11:47:41 2010 From: "Aaron Seigo" Date: Mon, 21 Jun 2010 11:47:41 +0000 To: kde-panel-devel Subject: Re: Review Request: Proper size for analog clock timezone label Message-Id: <20100621114741.11168.21629 () localhost> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=127712090927926 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0525389294==" --===============0525389294== Content-Type: multipart/alternative; boundary="===============8127233351318866185==" --===============8127233351318866185== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4418/#review6211 ----------------------------------------------------------- Ship it! i quite like the improved look, there is one change that needs to be made n= oted below, but then it can go in. /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.cpp in the case of a small analog clock with a long city name, this will re= sult in returning a rect that is wider than the widget. = so width needs to be bounded to rect.width(). = - Aaron On 2010-06-21 05:16:47, Alain Boyer wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4418/ > ----------------------------------------------------------- > = > (Updated 2010-06-21 05:16:47) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > This patch adjusts the timezone label of the analog clock to the width of= the city text. Although this is a cosmetic change that is very subjective,= I find that the overall look, when multiple clocks are horizontally aligne= d next to each other, is nicer and more polished. > = > This is a very minor change, but since I have been away from KDE hacking = for a while and we are so close to the next release, I figured I'd put it u= p for review. > = > = > Diffs > ----- > = > /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.= h 1140389 = > /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.= cpp 1140389 = > = > Diff: http://reviewboard.kde.org/r/4418/diff > = > = > Testing > ------- > = > Works just fine in plasmoidviewer. > = > = > Screenshots > ----------- > = > Before > http://reviewboard.kde.org/r/4418/s/440/ > After > http://reviewboard.kde.org/r/4418/s/441/ > = > = > Thanks, > = > Alain > = > --===============8127233351318866185== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde= .org/r/4418/

Ship it!

i quite like the improved look, there is one change that needs to be =
made noted below, but then it can go in.

= =

/trunk/KDE/kdebas= e/workspace/plasma/generic/applets/analog-clock/clock.cpp (Diff revision 1)

void Clock::paintInter=
face(QPainter *p, const QStyleOptionGraphicsItem *option, const QRect &=
rect)

<=
/pre>

433

 =
   return QRect((rect.width() -<=
/span> width) / 2, rect.bottom<=
/span>() - height, width<=
span class=3D"p">, height=
);

in the case of a small analog clock with a =
long city name, this will result in returning a rect that is wider than the=
 widget.

so width needs to be bounded to rect.width().

- Aaron

On June 21st, 2010, 5:16 a.m., Alain Boyer wrote:

Review request for Plasma.

By Alain Boyer.

Updated 2010-06-21 05:16:47

Descripti= on

This patch adjusts the timezone la=
bel of the analog clock to the width of the city text. Although this is a c=
osmetic change that is very subjective, I find that the overall look, when =
multiple clocks are horizontally aligned next to each other, is nicer and m=
ore polished.

This is a very minor change, but since I have been away from KDE hacking fo=
r a while and we are so close to the next release, I figured I'd put it=
 up for review.

Testing <= /h1>

Works just fine in plasmoidviewer.=

Diffs=

/trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock= .h (1140389)
/trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock= .cpp (1140389)

Screensho= ts

3D"Before"

3D"After"

--===============8127233351318866185==-- --===============0525389294== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0525389294==--