[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request: Fix some Event/Todo problems in Plasma Calendar
From: "John Layt" <johnlayt () googlemail ! com>
Date: 2010-06-19 21:41:12
Message-ID: 20100619214112.23935.69879 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4387/
-----------------------------------------------------------
Review request for Plasma.
Summary
-------
Fix some problems and make some improvements:
1) Todo items were not being cached or displayed as they don't have a Start=
Date. Instead return the TodoDueDate and other Todo details in the DataCont=
ainer for clients to use. Use the TodoDueDate to index and display Todo's,=
other details cannot be added due to string freeze (do in 4.6).
2) Only show Event times in Calendar pop-up, not dates as pop-up is for a s=
ingle date anyway
3) Tweak the whitespace in the pop-up
4) Cache Events/Todos as Data rather than display strings, only format disp=
lay strings at point of display
5) Generally make Event/Todo code more consistent with Holiday code
What still doesn't work correctly:
1) Recurring events only show first occurrence
2) Date range filter does not work, all Akonadi Events/Todos are returned a=
nd cached
3) New or modified Events/Todo's (e.g. in KOrganizer) do not auto-update in=
plasma as they should
4) There might be an issue with multi-day events not displaying on correct =
days
5) There might be issues with timezones
Still looking into these, may need help from the pimsters to work out why.
Diffs
-----
trunk/KDE/kdebase/workspace/libs/plasmaclock/calendartable.cpp 1139216 =
trunk/KDE/kdebase/workspace/plasma/generic/dataengines/calendar/eventdata=
container.cpp 1137927 =
Diff: http://reviewboard.kde.org/r/4387/diff
Testing
-------
Usual rounds of testing with plasmoidviewer and akonadi resources with plen=
ty of events and todos.
Thanks,
John
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4387/">http://reviewboard.kde.org/r/4387/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By John Layt.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">Fix some problems and make some improvements:
1) Todo items were not being cached or displayed as they don't have a StartDate. \
Instead return the TodoDueDate and other Todo details in the DataContainer for \
clients to use. Use the TodoDueDate to index and display Todo's, other details \
cannot be added due to string freeze (do in 4.6). 2) Only show Event times in \
Calendar pop-up, not dates as pop-up is for a single date anyway 3) Tweak the \
whitespace in the pop-up 4) Cache Events/Todos as Data rather than display strings, \
only format display strings at point of display 5) Generally make Event/Todo code \
more consistent with Holiday code
What still doesn't work correctly:
1) Recurring events only show first occurrence
2) Date range filter does not work, all Akonadi Events/Todos are returned and cached
3) New or modified Events/Todo's (e.g. in KOrganizer) do not auto-update in \
plasma as they should 4) There might be an issue with multi-day events not displaying \
on correct days 5) There might be issues with timezones
Still looking into these, may need help from the pimsters to work out why.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">Usual rounds of testing with plasmoidviewer \
and akonadi resources with plenty of events and todos.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdebase/workspace/libs/plasmaclock/calendartable.cpp <span \
style="color: grey">(1139216)</span></li>
<li>trunk/KDE/kdebase/workspace/plasma/generic/dataengines/calendar/eventdatacontainer.cpp \
<span style="color: grey">(1137927)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4387/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic