[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: [Quicklaunch] Fix handling of plain paths and
From:       "Ingomar Wesp" <ingomar () wesp ! name>
Date:       2010-06-10 21:25:24
Message-ID: 20100610212524.6173.64031 () localhost
[Download RAW message or body]



> On 2010-06-09 19:52:25, Lukas Appelhans wrote:
> > Good stuff...
> > 
> > 1) Can go in anyway...
> > 
> > 2) as well imo... just wait a few more hours, if there are no complains commit it :)
> > 
> > Lukas

Thanks!

Committing now.


- Ingomar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4271/#review6064
-----------------------------------------------------------


On 2010-06-09 19:06:31, Ingomar Wesp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4271/
> -----------------------------------------------------------
> 
> (Updated 2010-06-09 19:06:31)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Not sure if it's already too late for 4.5 (hence the review
> request), but the attached patch fixes two issues:
> 
> - Newly added URLs that only consist of a path ("/usr/share/[...]" as
>   opposed to "file:///usr/share/[...]") are now resolved into
>   full file-URLs before being passed to KDesktopFile. Among other
>   things, this fixes dragging items from application launcher
>   menus.
> 
> - The popup dialog now closes automatically after one of it's items
>   is clicked. Whether the previous behavior counts as a bug is
>   probably a matter of perspective, but IMHO it was a bit annoying.
>   
> Please tell me if I can commit this or if I should wait until trunk
> reopens.
> 
> Thanks!
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/icongrid.h 1135692 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/icongrid.cpp 1135692 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/quicklaunch.h 1135692 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/quicklaunch.cpp 1135692 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/quicklaunchicon.cpp 1135692 
> 
> Diff: http://reviewboard.kde.org/r/4271/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ingomar
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]