[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Modify Calendar Data Engine to not use multiple
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2010-06-10 16:08:54
Message-ID: 20100610160854.29188.37328 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4273/#review6079
-----------------------------------------------------------

Ship it!


awesome; sweet and simple :)

- Aaron


On 2010-06-10 09:56:03, John Layt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4273/
> -----------------------------------------------------------
> 
> (Updated 2010-06-10 09:56:03)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Remove use of insertMulti() by changing "holidays" data request to return a list \
> instead of a hash.  Holidays don't really have a unique key, neither date nor name \
> are unique, so a list of objects with attributes better matches the data than a \
> hash.  The date is simply another attribute of the holiday rather than being the \
> key (with more attributes to come in 4.6). 
> Alternatives:
> * Keep the hash with date as key, with a nested list of holidays for that date as \
>                 the value, which just seems over-complex to set-up and read.
> * Keep the hash but with a random meaningless key and the date as an attribute, \
> which is really just another name for a list. 
> 
> Diffs
> -----
> 
> trunk/KDE/kdebase/workspace/libs/plasmaclock/calendartable.cpp 1136478 
> trunk/KDE/kdebase/workspace/plasma/generic/dataengines/calendar/calendarengine.h \
> 1136478  trunk/KDE/kdebase/workspace/plasma/generic/dataengines/calendar/calendarengine.cpp \
> 1136478  
> Diff: http://reviewboard.kde.org/r/4273/diff
> 
> 
> Testing
> -------
> 
> Calendar plasmoid displays multiple holidays on same day with distinction between \
> days-off and days-on. 
> 
> Thanks,
> 
> John
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]