[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: 'fix' layout of notifications config page
From:       "Hugo Pereira Da Costa" <hugo () oxygen-icons ! org>
Date:       2010-06-06 21:07:55
Message-ID: 20100606210755.31030.9023 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4246/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

In the current "notifications" config page, checkboxes are presented with right \
aligned labels, and checkboxes on the right of these labels. As far as I know, this \
layout is used nowhere else in various UIs, and neither me nor Pinheiro could find a \
reason for this unusual layout. Is there any ?  This patch restores "normal" layout, \
with checkboxes on the left, and left-aligned labels, right of the checkbox.  See \
screenshots. 


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/notificationsconfig.ui \
1135215 

Diff: http://reviewboard.kde.org/r/4246/diff


Testing
-------

oxygen + trunk


Screenshots
-----------

current layout
  http://reviewboard.kde.org/r/4246/s/425/
proposed layout
  http://reviewboard.kde.org/r/4246/s/426/


Thanks,

Hugo

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]