[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Plasma-Mediacenter: Cosmetics for the playlist
From:       "Alessandro Diaferia" <alediaferia () gmail ! com>
Date:       2010-06-01 11:56:09
Message-ID: 20100601115609.2159.7017 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4167/#review5920
-----------------------------------------------------------


I like how the patch behaves.. Just some concerns:


trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/medialayout.cpp
<http://reviewboard.kde.org/r/4167/#comment5549>

    else needed



trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/medialayout.cpp
<http://reviewboard.kde.org/r/4167/#comment5550>

    This makes sense to me but how this apply to our particular PlaylistApplet? As \
far as i can see from your patch you disabled the BackgroundHint and drew the \
background on your own. So, how can this check apply to our applet?



trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/medialayout.cpp
<http://reviewboard.kde.org/r/4167/#comment5551>

    This shouldn't be needed as the handler updates its size accordingly when the \
applet it is watching changes size. If this doesn't happen then there's a bug in the \
handler code.


- Alessandro


On 2010-05-30 16:30:10, Christophe Olinger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4167/
> -----------------------------------------------------------
> 
> (Updated 2010-05-30 16:30:10)
> 
> 
> Review request for Plasma and Alessandro Diaferia.
> 
> 
> Summary
> -------
> 
> This (for once very small) patch stretches the playlist fully between the two \
> horizontal bars and makes it a bit wider. It also gives us the ability to theme the \
> playlist. Actually it looks best without any background when the use is browsing \
> things, but a background would be needed when a video is playing and the playlist \
> is shown. What do ya think?
> 
> Bug: The playlist handler does not correctly follow the resizing of the playlist
> 
> 
> Diffs
> -----
> 
> trunk/playground/base/plasma/MediaCenterComponents/applets/mediacontroller/controller.cpp \
> 1132326  trunk/playground/base/plasma/MediaCenterComponents/applets/mediainfobar/mediainfobar.cpp \
> 1132326  trunk/playground/base/plasma/MediaCenterComponents/applets/playlist/playlistapplet.h \
> 1132326  trunk/playground/base/plasma/MediaCenterComponents/applets/playlist/playlistapplet.cpp \
> 1132326  trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/medialayout.h \
> 1132326  trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/medialayout.cpp \
> 1132326  
> Diff: http://reviewboard.kde.org/r/4167/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christophe
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]