--===============1155607571==
Content-Type: multipart/signed;
  boundary="nextPart1396984.HbaYeXJJdH";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart1396984.HbaYeXJJdH
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

On May 25, 2010, Mike Kasick wrote:
> On Tue, May 25, 2010 at 10:20:46AM -0700, Aaron J. Seigo wrote:
> > kickoff is a popup applet should be handled by PopupApplet and so
> > shouldn't be patched for this.
>=20
> The "new-style" kickoff is indeed, I don't think the patches touch
> the regular LauncherApplet.  The "old-style" kickoff (better name for
> this?  simpleapplet?  Class MenuLauncherApplet anyways.) isn't a
> PopupApplet hence why I added the code there.
>=20
> > the PopupApplet patch needs work, however. in PopupApplet::sizeHint, it
> > should probably be something like:
> >=20
> > if (!d->icon) {
> >=20
> >     return Applet::sizeHint(which, constraint);
> >=20
> > }
>=20
> So actually, I wasn't quite sure if I had to do anything more when
> converting iconSize to a QSizeF.  In IconWidget and elsewhere
> IconWidget::sizeFromIconSize is used (e.g., icons.cpp:63).

good question;  sizeFromIconSize basically answers the question, "with the=
=20
given text for this icon, how bit does the whole QGraphicsWidget need to be=
 to=20
show both the text and the icon at that size"? in these cases no text is be=
ing=20
shown, so we don't really care.

> Is there a chance this will make it into 4.4.4?  If not, I might want to

i highly doubt it, sorry :(

> Figure there's likely to be a single SVN commit I can grab?  Otherwise I
> can take a look at the commit log and grab out the relevant pieces.

there was one commit per set of files changed; so one for PopupApplet in=20
libplasma, one for kickoff, one for lancelot (iirc?) and one for the contro=
l=20
panel.

> P.S.: While it's on my mind, I think I see another bug in
> IconWidget::sizeHint (kdelibs/plasma/widgets/iconwidget.cpp:675,691,696).
> The three return lines in this method all take "qMax(...height(),
> ...height()", I suspect that's supposed to be "qMax(...width(),
> ...height()".

yes, looks like a typo. nice catch.

=2D-=20
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks

--nextPart1396984.HbaYeXJJdH
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.12 (GNU/Linux)

iEYEABECAAYFAkv8J0QACgkQ1rcusafx20Pk3ACfb5ORYqHf11gDx0QwIApKA5iI
FxQAn1DMWclx5Frc3cCk4neBhv4FYks9
=aDIm
-----END PGP SIGNATURE-----

--nextPart1396984.HbaYeXJJdH--

--===============1155607571==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

--===============1155607571==--