[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Reset KRunner dialog size on query launch
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2010-05-21 19:50:09
Message-ID: 20100521195009.15408.73439 () localhost
[Download RAW message or body]



> On 2010-05-21 12:42:14, Marco Martin wrote:
> > yes, those are that little annoyance that make the difference :)
> 
> Ignat Semenov wrote:
> Don't have an SVN account yet; could you commit this for me?
> 
> Ignat Semenov wrote:
> Ping? Is this committed?

did it a while ago


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4086/#review5796
-----------------------------------------------------------


On 2010-05-21 12:27:30, Ignat Semenov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4086/
> -----------------------------------------------------------
> 
> (Updated 2010-05-21 12:27:30)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> After launching a query result from KRunner, the dialog size remains the same the \
> next time KRunner window is opened, that is, there is a large results area. \
> However, if you discard the result, the dialog is reset to normal size, that is, no \
> results area at all, which is inconsistent. This very simple patch fixes that. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.cpp 1128711 
> 
> Diff: http://reviewboard.kde.org/r/4086/diff
> 
> 
> Testing
> -------
> 
> Seems to work fine. Launched a query result, then hit Alt+F2, the default KRunner \
> window appeared. 
> 
> Thanks,
> 
> Ignat
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]