[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Stop using oxygen as a theme element fallback
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2010-05-07 16:10:32
Message-ID: 20100507161032.1405.27275 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3903/#review5500
-----------------------------------------------------------


Ivan and Marco are correct; however, could you provide examples or use cases of these \
common configurations and where things go wrong/bad? thanks :)

- Aaron


On 2010-05-07 13:17:50, Will Stephenson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3903/
> -----------------------------------------------------------
> 
> (Updated 2010-05-07 13:17:50)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> If a user starts Plasma on a machine where the configured desktop theme is not \
> available, a fallback is used for each element.  If the theme is completely \
> missing, default fallbacks, in order "oxygen" and "default" are used.  This means \
> that Oxygen elements are used in preference to Air elements.  With common \
> configurations, this results in black text on the black/dark Oxygen elements, which \
> is unusable. 
> This patch removes oxygen from the fallbacks, leaving "default" (Air).  Since both \
> oxygen and air are installed by kdebase-workspace they are equally likely to be \
> present. 
> 
> Diffs
> -----
> 
> trunk/KDE/kdelibs/plasma/theme.cpp 1123666 
> 
> Diff: http://reviewboard.kde.org/r/3903/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Will
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]