[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: basic activity manager
From:       "Chani Armitage" <chanika () gmail ! com>
Date:       2010-04-23 18:35:42
Message-ID: 20100423183542.16429.96424 () localhost
[Download RAW message or body]



> On 2010-04-23 08:20:21, Ivan Cukic wrote:
> > First, I'm getting two compilation problems - AbstractIcon and AbstractIconList \
> > are not in Plasma namespace. 
> > The other thing is that AbstractIcon and AbstractIconList don't have \
> > PLASMAGENERICSHELL_EXPORT so the linker fails as well. 
> > Did you make some patches to libs/plasmagenericshell as well?

(hmm, my comment seems to have vanished)

yes, forgot those patches, sorry.


- Chani


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3780/#review5180
-----------------------------------------------------------


On 2010-04-22 21:06:15, Chani Armitage wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3780/
> -----------------------------------------------------------
> 
> (Updated 2010-04-22 21:06:15)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> this is the beginning of the activity manager.
> it's not very pretty yet; it doesn't have many features yet; but it's a start.
> switching between activities and creating new ones works.
> 
> at the moment "activities" are still just containments; soon this will use the \
> proper activity API instead. 
> stuff that's not implemented yet:
> -responding to signals for anything other than added activities
> -showing a pretty thumbnail for each activity
> -start/stop/remove buttons
> -filtering
> 
> 
> Diffs
> -----
> 
> /dev/null PRE-CREATION 
> /dev/null PRE-CREATION 
> /dev/null PRE-CREATION 
> /dev/null PRE-CREATION 
> /dev/null PRE-CREATION 
> /dev/null PRE-CREATION 
> /dev/null PRE-CREATION 
> /dev/null PRE-CREATION 
> /trunk/KDE/kdebase/workspace/plasma/desktop/shell/CMakeLists.txt 1115355 
> /trunk/KDE/kdebase/workspace/plasma/desktop/shell/controllerwindow.h 1115355 
> /trunk/KDE/kdebase/workspace/plasma/desktop/shell/controllerwindow.cpp 1115355 
> /trunk/KDE/kdebase/workspace/plasma/desktop/shell/desktopview.h 1115355 
> /trunk/KDE/kdebase/workspace/plasma/desktop/shell/desktopview.cpp 1115355 
> /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelcontroller.cpp 1115355 
> /trunk/KDE/kdebase/workspace/plasma/desktop/shell/plasmaapp.h 1115355 
> /trunk/KDE/kdebase/workspace/plasma/desktop/shell/plasmaapp.cpp 1115355 
> 
> Diff: http://reviewboard.kde.org/r/3780/diff
> 
> 
> Testing
> -------
> 
> known issues:
> -removing a containment seems to crash ControllerWindow, because the destructor \
> tries to use the containment's corona. I'm wondering if there's a way to fix this \
> other than having ActivityManager store a pointer to the corona... of course it \
> wouldn't be a problem if we could delete things off the scene without removing them \
>                 first :/
> -if you make the activitymanager or widgetexplorer go away without clicking the \
> close button, its geometry is wrong the next time it's shown. not sure what's up \
> with that. 
> 
> Thanks,
> 
> Chani
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]