-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3513/#review5185
-----------------------------------------------------------

Ship it!


please commit these changes with two separate commits: one for the new class, one for the changes to the rotation animation.

also, we need a way to get to our pre-defined easing curves with a new factory method in Animator, just as we have for animations.


trunk/KDE/kdelibs/plasma/animations/pendulumcurve.h
<http://reviewboard.kde.org/r/3513/#comment4676>

    the class should not be exported.


- Aaron


On 2010-04-22 22:26:21, Bruno Abinader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3513/
> -----------------------------------------------------------
> 
> (Updated 2010-04-22 22:26:21)
> 
> 
> Review request for Plasma, Aaron Seigo, Marco Martin, igorto, and Adenilson Cavalcanti.
> 
> 
> Summary
> -------
> 
> The Plasma::PendulumCurve class subclasses from Qt's QEasingCurve and implements a static function which simulates a "pendulum" effect by varying the progress value from 0 to 1, 1 to 0, 0 to -1 and -1 to 0 in a linear way.
> 
> Together with this easing curve, some modifications were made on the Plasma::RotationAnimation to make the widget's rotation remain the last value given by updateEffectiveTime, and not a hard-coded one when the animation reaches the Stopped status.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/plasma/CMakeLists.txt 1117000 
>   trunk/KDE/kdelibs/plasma/animations/pendulumcurve.h PRE-CREATION 
>   trunk/KDE/kdelibs/plasma/animations/pendulumcurve.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/plasma/animations/rotation.cpp 1117000 
>   trunk/KDE/kdelibs/plasma/animations/rotation_p.h 1117000 
> 
> Diff: http://reviewboard.kde.org/r/3513/diff
> 
> 
> Testing
> -------
> 
> An example code was added to the "plasma applet animation example" (in kdeexamples/plasma/c++/plasmoid/animation). That code will be later commited, after this request gets successfully merged. You can grab the example code here: http://pastebin.com/cJtktUwR
> 
> 
> Thanks,
> 
> Bruno
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel